Repository navigation
Conversation
This adds hot reloading support for all the programs in elm/browser: - `Browser.sandbox` - `Browser.element` - `Browser.document` - `Browser.application` - `Debugger.element` - `Debugger.document` It needs support in `Platform` in elm/core to work.
The `popstate` event listener would be left behind due to calling the wrong `shutdown` function.
Not needed anymore since commit 8d636c387ffaa53815be565d601b4e1456e2a5ab in elm/core.
`stepper` is already a no-op when we send the `NoOp` message, so nothing would be re-drawn anyway. And we don’t need to redraw anything, because we are removing the entire debugger. (Usually when closing the debugger, we need to trigger a redraw so we stop rendering the debugger window and go back to rendering the corner. But now we are also removing the corner. The reason for the manual redraw trigger is because mutation is used behind the scenes for this.)
They were read from an object that is never mutated during hot reloading (even if it looked like it at first glance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR for elm/core#1155. See that one for details.
This PR is in my fork, since this PR is based on the
safebranch. By having the PR in my fork, I can choose thesafebranch as the base, so that the diff only shows the changes on top ofsafe.This PR also fixes the timing of the initial draw, fixing a bug where web components that emit events while being rendered causes Elm to crash.
It’s easier to read the diff ignoring whitespace changes since some parts were indented.