Conversation
The delegation service fixture changed TMPDIR/TEMP/TMP for its children but left Python's cached tempfile.tempdir untouched, so a warmed parent could route to a different Effect runtime than its native CLI children. It also left each case's private runtime alive until the five-minute idle shutdown, accumulating servers across the suite, including failed setups. Reuse the canonical isolate_sqlite_runtime helper for both routes and register a finalizer that shuts the fixture's own runtime down through the existing restart API. The extended isolation test fails on the old fixture and passes afterward; a neighboring runtime survives teardown. Ported from the closed loopx-project#5308 (13f4c93, bdbd440) as a standalone test-infrastructure change. Production code is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: song <liusongstep@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
Author Declaration
Implemented against
tests/test_local_delegation.pyuv run --extra test python -m pytest -q tests/test_local_delegation.py -k isolates_cached_and_child_runtime_routesScope And Continuation
Validation
759349919smokepassedtests/test_local_delegation.py::test_delegation_fixture_isolates_cached_and_child_runtime_routeson the fixed fixture (was failing on main).suitepassedtests/test_local_delegation.py(~32 cases).See validation disclosure guidance.
Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
Boundary Checklist
none.Signed-off-bytrailer (git commit -s).🤖 Generated with Claude Code