Skip to content

fix(control-plane): restore merged contract compatibility - #5533

Open
Duang777 wants to merge 6 commits into
loopx-project:mainfrom
Duang777:codex/fix-main-ci-contracts-20261003
Open

Duang777 wants to merge 6 commits into
loopx-project:mainfrom
Duang777:codex/fix-main-ci-contracts-20261003

Conversation

@Duang777

@Duang777 Duang777 commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

  • Outcome basis / optional anchor: CI regressions reproduced on current main; related to fix(ci): restore shared source qualification contracts #5526.
  • Goal/source and gap: Recent control-plane merges changed replan binding, lifecycle registry visibility, Codex session scope, and settled monitor projection contracts. A few production boundaries and fixtures still encoded the older contracts.
  • Observable before → after, with the validation row that proves it: Exact GoalRef manager-context delivery now works without enumerating lifecycle-only registries; settled monitor readback retains its receipt-bound Todo while execution stays closed; replan fixtures explicitly bind before settlement; agent-scoped recovery tests drift the agent identity; semantic inventories point to current symbols.
  • Issue/task and intended base: Related to fix(ci): restore shared source qualification contracts #5526; base main.

Author Declaration

  • Written by: model_agent, OpenAI Codex

Implemented against

  • Specification and revision: no separate written specification; merged contracts on main@e55489c77 and the request in this PR are the basis.
  • Criteria:
Criterion (spec clause) Disposition Symbol / path Test or command
Exact GoalRef delivery must not enumerate a lifecycle-only registry implemented source_context_target_authority manager-context and collaboration tests
Settled monitor identity remains observable without reopening execution implemented apply_settled_monitor_precedence settled monitor integration tests
Initial replan recommendation requires explicit same-Turn binding implemented quota settlement fixtures replan lifecycle tests
Agent-scoped Codex recovery compares agent identity implemented turn executor recovery fixture tests/test_loopx_turn_executor.py

Scope And Continuation

Validation

  • Tested revision: 17590f29b
  • Run state: finished
  • Input classes: synthetic
Check kind Result Public-safe evidence / limitation
unit passed 460 relevant Python tests across quota, monitor, manager-context, collaboration, Turn executor, and architecture suites
static passed Ruff on all changed Python files; git diff --check
integration passed CLI/effect-runtime monitor, replan settlement, lifecycle registry denial, and exact GoalRef roundtrip suites
regression_parity passed Reproduced the stale agent-scope fixture and inventory-anchor failures before correction; affected tests pass at the tested revision
static passed Project registry I/O manifest regenerated with 275 classified sites and verified current
  • Coverage and gaps: The changed production boundaries and their direct callers are covered. Full repository CI is delegated to the PR checks; no real backend is required for these local control-plane contracts.

Frontend / Visual Evidence

  • UI impact: none
  • Before: N/A
  • After: N/A
  • States and viewports shown: N/A
  • Source data: none
  • Attention review: N/A; no user-visible UI changed.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring (no functional changes)
  • Documentation update
  • Test update

LoopX Area

  • Control plane (goals, todos, quota, scheduler, registry, runtime)
  • Benchmark boundary (adapters, runners, verifiers, scoring, evidence)
  • Capability or extension (providers, adapters, skills)
  • Public docs or presentation surface (README, protocols, dashboard)
  • Build, packaging, installer, or CI
  • Host or runtime integration

Technical Direction

  • Direction / acceptance reference, when applicable: Shared Goal Authority and cross-host coordination.

Shared-authority RFC fixture impact

  • Production-scale fixture schema: unchanged
  • Semantic dimensions changed, or reviewed no-impact rationale: Exact GoalRef target authorization is separated from recipient catalog enumeration; no schema change.
  • Provider conformance arms run: legacy, file, and SQLite monitor-provider arms.
  • Read-only legacy/file/PostgreSQL three-arm rehearsal (required for promotion, runtime-routing, or compatibility-projection changes): not applicable; this PR does not promote a provider or change runtime routing.

Boundary Checklist

  • Neither the diff nor this PR body/comments/attachments disclose private state, credentials, raw traces or verifier output, internal links, or local machine paths (including .loopx/, .codex/goals/, and live ACTIVE_GOAL_STATE.md).
  • I did not duplicate maintainer-owned benchmark work unless a maintainer split out a public issue for it.
  • I kept the change scoped to the linked issue/task.
  • I completed the visual evidence section for UI changes, or marked UI impact none.
  • Every commit includes a DCO Signed-off-by trailer (git commit -s).

Preserve receipt-bound monitor readback without reopening execution, authorize exact GoalRef context delivery without enumerating lifecycle registries, and align replan/session fixtures with the merged contracts.

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777
Duang777 requested a review from steven-kid as a code owner October 3, 2026 15:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant