Conversation
Share Logs now bundles the notice file and the log files into a single zip archive before opening the share sheet. The archive is created with NSFileCoordinator, so no new dependency is needed. If zipping fails the files are shared uncompressed as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log files can get large enough that mail apps warn about the attachment size when sharing them. Share Logs now puts the notice file and the log files into a single zip archive and hands that to the share sheet. The archive is named LoopFollow Logs YYYY-MM-DD_HHMM.zip and unpacks to a folder with the same name.
The zip is created with NSFileCoordinator and the forUploading option, so there is no new dependency. Zipping runs off the main thread. If it fails, the error is logged and the files are shared uncompressed as before.