Skip to content

Drop the Cask/StanzaOrder exception from tap CI - #12

Merged
joe4dev merged 1 commit into
mainfrom
drop-stanza-order-exception
Oct 30, 2026
Merged

joe4dev merged 1 commit into
mainfrom
drop-stanza-order-exception

Conversation

@joe4dev

@joe4dev joe4dev commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Motivation

#10 skipped Cask/StanzaOrder in the cask style check because lstk's interim custom_block put the quarantine stanza first. localstack/lstk#512 switched to GoReleaser 2.19's hooks.post.install_steps, which puts the stanza in its correct place.

Solution

Drop --except-cops=Cask/StanzaOrder and its TODO.

Merge after the next lstk release

This PR will fail CI until then. The cask on main was generated by v1.4.2 (before #512), and brew style reports 11 Cask/StanzaOrder offences on it. The next weekly release (Thursday 2026-10-29) regenerates the cask. A cask built from lstk main already passes with no exception. After that release, update this branch from main and re-run CI.

The formula half of #10 (continue-on-error) was already resolved in #11.

🤖 Generated with Claude Code

Related

Closes DEVX-1130

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joe4dev
joe4dev force-pushed the drop-stanza-order-exception branch from 49ca2ca to dcfe0f1 Compare October 30, 2026 08:28
@joe4dev
joe4dev marked this pull request as ready for review October 30, 2026 08:41
@joe4dev
joe4dev requested a review from anisaoshafi October 30, 2026 08:41
@joe4dev
joe4dev merged commit b9c4c79 into main Oct 30, 2026
1 check passed
@joe4dev
joe4dev deleted the drop-stanza-order-exception branch October 30, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants