Repository navigation
ci: add integration job and tests for acme-commerce-lenders #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
localstack-platform
wants to merge
9
commits into
main
Choose a base branch
from
localstack/init-proj_5f62a1e8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d284db5
Add LocalStack CI workflow (localstack-app-emulators)
localstack-platform[bot] 406d5c1
Update LocalStack CI workflow (localstack-app-emulators)
localstack-platform[bot] d177393
ci: fold the LocalStack job into ci.yml and add integration tests
whummer 8b5335f
ci: use only LocalStack-hosted app emulators in the integration job
whummer a15ff6e
ci: run the demo inside the integration test
whummer 6d5fcf1
ci: show why the integration reset fails and find the LocalStack logs
whummer ab1277f
ci: probe the app emulators in the integration job
whummer 0f5dcf0
ci: run the app emulators LocalStack does not host
whummer cabf9c4
ci: address review feedback on the integration job
whummer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three smaller things, none blocking:
lstkinstall is unpinned and the wheel comes from the localstack-artifacts-internal bucket with no hash, in a public repo. Worth confirming with the platform team that this is intended.