Repository navigation
[lib][uefi] update GBL protocol headers from upstream - #543
Merged
zhangxp1998 merged 3 commits intoOct 21, 2026
Merged
Conversation
Sync lib/uefi/include/uefi with upstream GBL libefi_types headers: - Bump GBL protocol revisions to 1.0 (and 1.1 for OS configuration). - Standardize protocol GUID definitions in protocol headers via EFI_GUID and drop duplicate definitions from boot_service_provider.h. - Update EfiDtFixupProtocol.fixup signature and GUID to the latest revision. - Add fixup_kernel_commandline to GblEfiOsConfigurationProtocol with a default weak stub returning EFI_STATUS_UNSUPPORTED. - Remove deprecated gbl_efi_image_loading_protocol.h and duplicate gbl_efi_fastboot_transport.h.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
dimorinny
suggested changes
Oct 20, 2026
dimorinny
left a comment
dimorinny
left a comment
Contributor
There was a problem hiding this comment.
One blocker inline: the DT fixup default overflows the heap, and this PR makes it reachable from current GBL.
Allocate length + sizeof(to_add) - 1 bytes and call fdt_open_into() before growing chosen/bootargs in efi_dt_fixup(), and exclude the trailing NUL from final_len in fixup_bootconfig().
dimorinny
approved these changes
Oct 20, 2026
Print bootconfig with %.*s bounded by bootconfig_size and return EFI_STATUS_BUFFER_TOO_SMALL when fixup_buffer_size is insufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
lib/uefi/include/uefiwith upstream GBLlibefi_typesheaders:1.0(and1.1forGBL_EFI_OS_CONFIGURATION_PROTOCOL).EFI_GUIDand drop duplicate definitions fromboot_service_provider.h.EfiDtFixupProtocol.fixupsignature and GUID to match the latest revision.fixup_kernel_commandlinetoGblEfiOsConfigurationProtocolwith a default weak stub returningEFI_STATUS_UNSUPPORTED.gbl_efi_image_loading_protocol.hand duplicategbl_efi_fastboot_transport.h.