Skip to content

Evince Backport: Allow adding Highlight annotations from text selection - #493

Merged
clefebvre merged 2 commits into
linuxmint:masterfrom
m8:backport--selected-annotation
Jun 20, 2022
Merged

clefebvre merged 2 commits into
linuxmint:masterfrom
m8:backport--selected-annotation

Conversation

@m8

@m8 m8 commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

It is really practical to be able to add it as highlight after selecting the text. Constantly, it's hard to add from the menu. I backported it from Evince. Might be a good PR if you can test it.

Backported by Musa Unal

Taken from:
[1] https://gitlab.gnome.org/GNOME/evince/-/commit/fc0d21167185b34955f4996b35b0c479e0d482f3
[2] https://gitlab.gnome.org/GNOME/evince/-/merge_requests/198/diffs?commit_id=07d0461045be13bccf13b1145c266e7e61bb75e8

[1] commit fc0d21167185b34955f4996b35b0c479e0d482f3
[2] commit 07d0461045be13bccf13b1145c266e7e61bb75e8
Author: Nelson Benitez

As this is a natural, intuitive way to add text markup
annotations to a document.

The "Highlight Selected Text" action
in the context menu
will show if there is a selection. When
the selection spreads over several pages,
one annotation per page will be added accordingly
to fulfill the user expectation of all selected text
to be annotated.

https://bugzilla.gnome.org/show_bug.cgi?id=763943

@m8

m8 commented Jun 7, 2021

Copy link
Copy Markdown
Contributor Author

I noticed that there are some bugs in the annotation locations when it is saved. I am working on it.

@clefebvre clefebvre changed the title Evince Backport: Allow adding Highlight annotations from text selection [NEXT] Evince Backport: Allow adding Highlight annotations from text selection Jun 10, 2021
@sidmint

sidmint commented Jun 21, 2021

Copy link
Copy Markdown

just mentioning that, apart from context menu facility, directly pressing ctrl H and alt H highlights too, in evince and deepin reader respectively, after selecting text.

@m8

m8 commented Jun 21, 2021

Copy link
Copy Markdown
Contributor Author

@sidmint yes it will be nice, there was a small bug about saving locations of annotations. after fix ıt can be implemented very easily.

@clefebvre clefebvre changed the title [NEXT] Evince Backport: Allow adding Highlight annotations from text selection Evince Backport: Allow adding Highlight annotations from text selection Jul 28, 2021
@clefebvre clefebvre changed the title Evince Backport: Allow adding Highlight annotations from text selection [Next] Evince Backport: Allow adding Highlight annotations from text selection Nov 23, 2021
@clefebvre clefebvre changed the title [Next] Evince Backport: Allow adding Highlight annotations from text selection Evince Backport: Allow adding Highlight annotations from text selection Jan 17, 2022
@clefebvre
clefebvre merged commit 01b302c into linuxmint:master Jun 20, 2022
@m8

m8 commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

@clefebvre could you revert this commit, i experienced some bugs but apparently i forget to close pr.

m8 added a commit to m8/xreader that referenced this pull request Jun 20, 2022
mtwebster pushed a commit that referenced this pull request Jul 18, 2022
@tyagi-ankit

Copy link
Copy Markdown

Hi, this feature is still not there, right?

@sidmint

sidmint commented Sep 12, 2026

Copy link
Copy Markdown

#547 similar request.
This basic feature is still missing and manual option of adding highlight/annotate is very unintuitive to find.
Evince got this long ago, new epub reader to be launched which is mentioned in blog has it from day one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants