You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is really practical to be able to add it as highlight after selecting the text. Constantly, it's hard to add from the menu. I backported it from Evince. Might be a good PR if you can test it.
[1] commit fc0d21167185b34955f4996b35b0c479e0d482f3
[2] commit 07d0461045be13bccf13b1145c266e7e61bb75e8
Author: Nelson Benitez
As this is a natural, intuitive way to add text markup
annotations to a document.
The "Highlight Selected Text" action
in the context menu
will show if there is a selection. When
the selection spreads over several pages,
one annotation per page will be added accordingly
to fulfill the user expectation of all selected text
to be annotated.
https://bugzilla.gnome.org/show_bug.cgi?id=763943
I noticed that there are some bugs in the annotation locations when it is saved. I am working on it.
clefebvre
changed the title
Evince Backport: Allow adding Highlight annotations from text selection
[NEXT] Evince Backport: Allow adding Highlight annotations from text selection
Jun 10, 2021
just mentioning that, apart from context menu facility, directly pressing ctrl H and alt H highlights too, in evince and deepin reader respectively, after selecting text.
@sidmint yes it will be nice, there was a small bug about saving locations of annotations. after fix ıt can be implemented very easily.
clefebvre
changed the title
[NEXT] Evince Backport: Allow adding Highlight annotations from text selection
Evince Backport: Allow adding Highlight annotations from text selection
Jul 28, 2021
clefebvre
changed the title
Evince Backport: Allow adding Highlight annotations from text selection
[Next] Evince Backport: Allow adding Highlight annotations from text selection
Nov 23, 2021
clefebvre
changed the title
[Next] Evince Backport: Allow adding Highlight annotations from text selection
Evince Backport: Allow adding Highlight annotations from text selection
Jan 17, 2022
#547 similar request.
This basic feature is still missing and manual option of adding highlight/annotate is very unintuitive to find.
Evince got this long ago, new epub reader to be launched which is mentioned in blog has it from day one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is really practical to be able to add it as highlight after selecting the text. Constantly, it's hard to add from the menu. I backported it from Evince. Might be a good PR if you can test it.
Backported by Musa Unal
Taken from:
[1] https://gitlab.gnome.org/GNOME/evince/-/commit/fc0d21167185b34955f4996b35b0c479e0d482f3
[2] https://gitlab.gnome.org/GNOME/evince/-/merge_requests/198/diffs?commit_id=07d0461045be13bccf13b1145c266e7e61bb75e8
[1] commit fc0d21167185b34955f4996b35b0c479e0d482f3
[2] commit 07d0461045be13bccf13b1145c266e7e61bb75e8
Author: Nelson Benitez