Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix context menu handling in the tree sidebar when there is no valid file associated with the target row.
This fixes two existing crash cases:
popup_file. Selecting Properties could then crash Nemo.(Empty)placeholder of an empty directory provides a tree path, but no correspondingNemoFile, which could also lead to a crash.While testing the fix, I also found that invoking the context menu from the keyboard (Shift+F10) could crash when the tree view had focus but no valid row was selected. In this case the
popup-menusignal callspopup_menu()without aGdkEventButton, whileupdate_menu_states()unconditionally dereferenced the event.The change:
NemoFile;Tested with a local build of Nemo 6.7.6:
(Empty)placeholder: no menu, no crash;