Repository navigation
fix: correct the scan manager help manual screenshots and step numbering (V-5777) - #52
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR fixes locale-specific screenshot references in the scan manager help manual for Simplified and Traditional Chinese editions, retains shared imagery for English, and corrects the zh_CN camera instructions to use consecutive steps 1–3. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
re2zero
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="assets/deepin-scanner/scan-manager/zh_CN/scan-manager.md" line_range="36" />
<code_context>
打开扫描管理器，系统会自动扫描当前电脑上连接的所有扫描设备，如拍摄仪和扫描仪。如果没有显示对应的设备列表，则需要安装驱动。
-
+
### 安装驱动
</code_context>
<issue_to_address>
**Chinese help screenshots are broken**
When a user opens any affected Simplified or Traditional Chinese help page, the Markdown image links resolve under `../common/`, but `homepage_zh.png`, `homepage_hk.png`, `camera_settings_zh.png`, and `camera_settings_hk.png` are absent from the repository, so the pages show broken-image placeholders instead of screenshots.
Add the missing image files or update the links to point to screenshots that exist.
Also at `assets/deepin-scanner/scan-manager/zh_CN/scan-manager.md:49`, `assets/deepin-scanner/scan-manager/zh_HK/scan-manager.md:28`, `assets/deepin-scanner/scan-manager/zh_HK/scan-manager.md:40`, `assets/deepin-scanner/scan-manager/zh_TW/scan-manager.md:31`, `assets/deepin-scanner/scan-manager/zh_TW/scan-manager.md:45`.
</issue_to_address>
Every locale of the help manual pointed at the same Simplified Chinese screenshots, and the zh_CN section for the camera numbered its steps 1, 2, 4. The manual now references a screenshot per locale (Simplified Chinese _zh, Traditional Chinese _hk, English keeps the shared images) and the zh_CN step is numbered 3. 帮助手册各语言版本共用同一组简体中文界面截图，且 zh_CN 拍摄仪章节的步骤编号为 1、2、4。 现按语言引用对应截图（简中 _zh、繁中 _hk，英文沿用共用图），zh_CN 的编号改为 3。 Log: 修正扫描管理器帮助手册的分语言截图与步骤编号 PMS: BUG-324749 (V-5777), BUG-325143 (V-5776) Influence: 简体/繁体中文帮助手册显示对应语言的界面截图，zh_CN 拍摄仪章节步骤编号为 1、2、3。
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="assets/deepin-scanner/scan-manager/zh_CN/scan-manager.md" line_range="36" />
<code_context>
打开扫描管理器，系统会自动扫描当前电脑上连接的所有扫描设备，如拍摄仪和扫描仪。如果没有显示对应的设备列表，则需要安装驱动。
-
+
### 安装驱动
</code_context>
<issue_to_address>
**Localized screenshots do not load**
When a user opens one of the affected locale manuals, the manuals link to `homepage_zh.png`, `homepage_hk.png`, `camera_settings_zh.png`, and `camera_settings_hk.png`, but those files are absent from the referenced `common` directory, so the localized screenshots appear broken.
Add the referenced screenshot assets at those paths, or change the links to files that are present.
Also at `assets/deepin-scanner/scan-manager/zh_CN/scan-manager.md:49`, `assets/deepin-scanner/scan-manager/zh_HK/scan-manager.md:28`, `assets/deepin-scanner/scan-manager/zh_HK/scan-manager.md:40`, `assets/deepin-scanner/scan-manager/zh_TW/scan-manager.md:31`, `assets/deepin-scanner/scan-manager/zh_TW/scan-manager.md:45`.
</issue_to_address>
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 语法正确，逻辑清晰。Markdown 语法使用规范，图片引用路径正确，步骤编号修复合理（1,2,4→1,2,3）。 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 代码结构清晰，注释完整。三个语言版本的 .md 文件变更保持一致性，.gitignore 新增条目合理。 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好，资源使用合理。本次变更为文档和配置文件修改，无性能影响。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 存在0个安全漏洞，无安全风险。本次变更不涉及用户输入处理、命令执行或敏感信息操作。 💡 改进建议代码示例// 本次变更为文档修正，无需代码改进示例
// 变更内容：
// 1. .gitignore: 新增 .openbitfun/ 目录忽略
// 2. zh_CN/scan-manager.md: homepage.png -> homepage_zh.png, camera_settings.png -> camera_settings_zh.png, 步骤4->3
// 3. zh_HK/scan-manager.md: homepage.png -> homepage_hk.png, camera_settings.png -> camera_settings_hk.png
// 4. zh_TW/scan-manager.md: homepage.png -> homepage_hk.png, camera_settings.png -> camera_settings_hk.png本报告由 AI 代码审查工具自动生成 |
lzwind
approved these changes
Oct 15, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every locale of the help manual pointed at the same Simplified Chinese screenshots, and the zh_CN section for the camera numbered its steps 1, 2, 4. The manual now references a screenshot per locale (Simplified Chinese _zh, Traditional Chinese _hk, English keeps the shared images) and the zh_CN step is numbered 3.
帮助手册各语言版本共用同一组简体中文界面截图，且 zh_CN 拍摄仪章节的步骤编号为 1、2、4。
现按语言引用对应截图（简中 _zh、繁中 _hk，英文沿用共用图），zh_CN 的编号改为 3。
Log: 修正扫描管理器帮助手册的分语言截图与步骤编号
PMS: BUG-324749 (V-5777), BUG-325143 (V-5776)
Influence: 简体/繁体中文帮助手册显示对应语言的界面截图，zh_CN 拍摄仪章节步骤编号为 1、2、3。
Summary by Sourcery
Correct scan manager help manual localization and camera instruction numbering.
Bug Fixes:
Documentation:
Closes V-5777