Repository navigation
fix: correct paper size label to page format in translations - #48
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR replaces the scan settings “Paper Size” label with the approved page-format terminology across the base, Simplified Chinese, and Traditional Chinese translations; behavior and application logic remain unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
206ba4b to
13264cf
Compare
deepin pr auto reviewAI 代码审查报告
总体评价
本次 PR 修改了 5 个 Qt 翻译文件(.ts)，将扫描设置界面中"Paper Size"的中文翻译从"纸张尺寸"更正为"幅面设置"(简体中文) / "幅面設置"(繁体中文)，直接修复了 PMS Bug #346615 中描述的文案显示错误问题。变更范围明确，仅涉及翻译文本，不涉及功能逻辑变更。 zh_CN、zh_HK、zh_TW 三个语言文件的翻译修改正确且符合 Bug 需求。基础模板(deepin-scanner.ts)和英文翻译(deepin-scanner_en_US.ts)被清空为 漏洞统计
漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 四维度评分1. 语法逻辑 ✓ (25/25)
分析:
2. 代码质量 ✓ (21/25)
分析: 正确之处:
质量问题:
3. 代码性能 ✓ (20/20)
分析:
4. 代码安全 ✓ (30/30)
分析:
OCR 审查结果OCR 审查共发现 2 条建议(非安全漏洞):
修改文件清单
改进建议建议完善基础模板和英文翻译将基础模板和英文翻译从 <!-- translations/deepin-scanner.ts -->
<translation>幅面设置</translation>
<!-- translations/deepin-scanner_en_US.ts -->
<translation>Page Format</translation>审查结论本次 PR 正确修复了 PMS Bug #346615 中描述的"纸张尺寸"文案显示错误问题，将中文翻译更正为"幅面设置"。zh_CN、zh_HK、zh_TW 三个语言文件的修改完全符合需求。建议同时完善基础模板和英文翻译文件的翻译内容，避免留空为 代码安全维度无漏洞，语法逻辑正确，性能无影响，代码质量良好。 |
1. Root cause: the Chinese translation for "Paper Size" was "纸张尺寸" (paper size), but the product requirement specifies "幅面设置" (page format setup) as the correct UI label 2. Fix: update the translation in four .ts files (zh_CN, zh_TW, zh_HK, en_US) to use "幅面设置" / "幅面設置" / "Page Format"; the base template (deepin-scanner.ts) is left as <translation type="unfinished"> </translation> since it is the default template 3. Impact: only the displayed label text changes, no functional or logic changes Log: 更正扫描设置中"纸张尺寸"文案为"幅面设置" Influence: 1. Verify the scan settings page shows "幅面设置" instead of "纸张尺寸" 2. Verify the label displays correctly in Simplified Chinese, Traditional Chinese (TW/HK) 3. Verify the English (en_US) label shows "Page Format" fix: 修正扫描设置中"纸张尺寸"文案为"幅面设置" 1. 根因：扫描设置界面"Paper Size"的中文翻译为"纸张尺寸"，但产品要求 显示为"幅面设置" 2. 方案：修改四个翻译文件（zh_CN、zh_TW、zh_HK、en_US）中的翻译为 "幅面设置"/"幅面設置"/"Page Format"；基础模板 deepin-scanner.ts 保持 unfinished 不翻译 3. 影响：仅修改界面显示文案，不涉及功能逻辑变更 Log: 更正扫描设置中"纸张尺寸"文案为"幅面设置" Influence: 1. 验证扫描设置页面显示"幅面设置"而非"纸张尺寸" 2. 验证简体中文、繁体中文（台湾/香港）下文案显示正确 3. 验证英文（en_US）下文案显示为"Page Format" PMS: BUG-346615
13264cf to
bc957bf
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
fix: correct paper size label to page format in translations
(paper size), but the product requirement specifies "幅面设置" (page
format setup) as the correct UI label
and the base template) to use "幅面设置" / "幅面設置"
logic changes
Log: 更正扫描设置中"纸张尺寸"文案为"幅面设置"
Influence:
fix: 修正扫描设置中"纸张尺寸"文案为"幅面设置"
显示为"幅面设置"
为"幅面设置"或"幅面設置"
Log: 更正扫描设置中"纸张尺寸"文案为"幅面设置"
Influence:
PMS: BUG-346615
Summary by Sourcery
Align scanner settings translations with the intended “Page Format” label across supported locales.
Bug Fixes:
Chores: