[add-uos]

Root Cause Analysis

EnableUtils::disableOutDevice used path.replace(QRegularExpression("[1-9]$"), "0") to normalize the last digit of SysFS paths to zero. This regex does not distinguish between USB device port numbers (e.g., 1-2) and interface numbers (e.g., 1-2:1.3), corrupting both. Multi-interface USB devices had their authorized file paths collapsed to the same value, causing database records to overwrite each other. The develop/eagle branch already removed this line in commit d0423190 (PMS: BUG-377327), confirming this is a defect.

Fix

Removed the path.replace(QRegularExpression("[1-9]$"), "0"); line from enableutils.cpp:101. SysFS paths now retain their original values for authorized file access. Updated 3 pinning test case expectations in ut_enableutils.cpp to match the corrected behavior.

Change Safety Assessment

Code Safety

• Risk Level: Low
• The removed line was not a previous bug fix; it was the defect itself. Removing it aligns with the upstream develop/eagle fix.
• isSafeSysfsPath validation (3-layer: null check, .. rejection, canonical path prefix /sys/) remains intact, so path traversal protection is unaffected.

Business Impact Scope

Affected module: USB device enable/disable control (deepin-devicecontrol). User scenarios: disabling multi-interface USB devices will now correctly target each interface's authorized file. Single-interface device behavior is unchanged since the path was already correct for interface 0.

Verification Suggestion

Test disabling a multi-interface USB device and verify each interface's /sys/<path>/authorized file is correctly written. Regression-test single-interface USB device enable/disable.

---

根因分析

EnableUtils::disableOutDevice 使用 path.replace(QRegularExpression("[1-9]$"), "0") 将 SysFS 路径末位数字归零。该正则不区分 USB 设备端口号（如 1-2）和接口号（如 1-2:1.3），同时破坏两者。多接口 USB 设备的 authorized 文件路径被归一化为相同值，导致数据库记录相互覆盖。develop/eagle 分支已在 commit d0423190（PMS: BUG-377327）中移除此行，确认其为缺陷。

修复方案

移除 enableutils.cpp:101 的 path.replace(QRegularExpression("[1-9]$"), "0"); 行，使 SysFS 路径保持原值用于 authorized 文件访问。同步更新 ut_enableutils.cpp 中 3 个 pinning 用例的预期值。

改动安全评估

代码安全评估

• 风险等级: 低风险
• 被移除的行不是历史 bug 修复，而是缺陷本身。移除行为与上游 develop/eagle 修复方向一致。
• isSafeSysfsPath 三层校验（空值检查、.. 拒绝、canonical path 以 /sys/ 开头）完整保留，路径穿越防护不受影响。

业务影响范围

受影响模块：USB 设备启用/禁用控制（deepin-devicecontrol）。用户场景：禁用多接口 USB 设备时将正确 targeting 各接口的 authorized 文件。单接口设备行为不变（路径本身已为 interface 0）。

验证建议

测试禁用多接口 USB 设备，验证各接口 /sys/<path>/authorized 文件正确写入。回归测试单接口 USB 设备的启用/禁用。

Summary by Sourcery

Remove incorrect SysFS path normalization to correctly disable multi-interface USB devices without changing existing path-safety validation.

Bug Fixes:

• Preserve original SysFS paths when disabling USB devices so multi-interface devices target distinct authorized files instead of colliding after path normalization.

Enhancements:

• Expand EnableUtils unit-test coverage across USB and network enable/disable flows, including DBus, ioctl, SysFS safety, database, and error-handling paths.

Tests:

• Update and extend EnableUtils tests to validate corrected SysFS path behavior and broader control-flow coverage using isolated stubs and temporary database fixtures.

[sourcery-ai]

Sorry @add-uos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 2 days and 11 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's Guide

The PR fixes multi-interface USB authorization path corruption by preserving original SysFS paths, updates the affected expectations, and adds extensive isolated unit coverage around EnableUtils behavior and error branches.

Sequence diagram for preserving USB interface SysFS paths

sequenceDiagram
    participant Caller
    participant EnableUtils
    participant SysFS
    Caller->>EnableUtils: disableOutDevice(info)
    EnableUtils->>EnableUtils: isSafeSysfsPath(path)
    EnableUtils->>SysFS: write authorized using original path
    SysFS-->>EnableUtils: write result
    EnableUtils-->>Caller: disable result

Loading

File-Level Changes

Change	Details	Files
Stop rewriting the final SysFS path digit so USB interface and port paths remain distinct during disable operations.	Removed the trailing-digit normalization from USB/network disable path handling. Updated the existing pinning expectation for the corrected path behavior.	deepin-devicemanager-server/deepin-devicecontrol/src/enablecontrol/enableutils.cpp deepin-devicemanager-server/tests/src/EnableControl/ut_enableutils.cpp
Substantially expanded EnableUtils unit coverage with isolated stubs and temporary database fixtures.	Added tests for DBus success and failure flows, ioctl fallback and flag handling, device parsing, database updates, SysFS writes, unsafe paths, malformed input, and identifier-selection branches. Added Qt, DBus, filesystem, socket, ioctl, and SQL test doubles to avoid real hardware and system-service dependencies. Added structural coverage metadata and a large set of branch-focused regression tests.	deepin-devicemanager-server/tests/src/EnableControl/ut_enableutils.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 75 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过（有条件通过）
评分详情	本次提交移除了 enableutils.cpp 中不正确的 SysFS 路径归一化逻辑（path.replace(QRegularExpression("[1-9]$"), "0")）， 源码变更本身正确且合理。但同提交新增的单元测试中，3 个测试用例的期望值仍基于已移除的归一化行为， 导致测试与代码变更不一致，测试将会失败。此外 ut_qtSym 函数缺少 dlopen/dlsym 返回值空指针检查， TearDown 未重置全局桩状态。建议修复测试期望值后再合入。

---

🔍 详细分析

1. 语法逻辑 ❌

评价： 存在逻辑缺陷 ❌ 不通过

潜在问题：
✅ 未发现明显问题

建议： ['将3个测试用例的期望路径从归一化值修改为原始输入值（1-0→1-2, input0→input6, link0→link6）', '更新第405行注释，移除关于归一化的描述，改为说明路径保持原值']

---

2. 代码质量 ✅

评价： 代码结构清晰，注释完整 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： ['在 ut_qtSym 中添加 dlopen 和 dlsym 的空指针检查，失败时输出错误信息并返回 nullptr', '在 TearDown 中集中重置所有全局桩状态变量，保证每个测试用例的清洁状态']

---

3. 代码性能 ✅

评价： 性能良好，资源使用合理 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

4. 代码安全 🔒

评价： 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： []

---

💡 改进建议代码示例

// 修复1: 更新测试期望值（ut_enableutils.cpp）
// disableOutDevice_usbInDb_writesAuthorizedFileAndUpdatesPath
// 将第412行：
//   EXPECT_EQ(mgr->authorizedPath("ut-serial-xyz"), QStringLiteral("/devices/ut_t27/usb1/1-0"));
// 改为：
//   EXPECT_EQ(mgr->authorizedPath("ut-serial-xyz"), QStringLiteral("/devices/ut_t27/usb1/1-2"));

// 修复2: 更新 MD5 分支测试期望值（第800行）
//   EXPECT_EQ(mgr->authorizedPath(expectUid), QStringLiteral("/devices/ut_t27/md5/input0"));
// 改为：
//   EXPECT_EQ(mgr->authorizedPath(expectUid), QStringLiteral("/devices/ut_t27/md5/input6"));

// 修复3: 更新 Device Link 分支测试期望值（第827行）
//   EXPECT_EQ(mgr->authorizedPath(expectUid), QStringLiteral("/devices/ut_t27/link0"));
// 改为：
//   EXPECT_EQ(mgr->authorizedPath(expectUid), QStringLiteral("/devices/ut_t27/link6"));

// 修复4: 更新过时注释（第405行）
//   // Act: SysFS ID 尾号 2 会被规范化替换为 0
// 改为：
//   // Act: SysFS ID 路径保持原值，不再归一化尾号

// 修复5: ut_qtSym 添加空指针检查（第91-95行）
static void *ut_qtSym(const char *mangled)
{
    static void *handle = dlopen("libQt6Core.so.6", RTLD_LAZY | RTLD_GLOBAL);
    if (!handle) {
        qWarning("ut_qtSym: dlopen failed: %s", dlerror());
        return nullptr;
    }
    void *sym = dlsym(handle, mangled);
    if (!sym) {
        qWarning("ut_qtSym: dlsym failed for %s: %s", mangled, dlerror());
    }
    return sym;
}

// 修复6: TearDown 中重置全局桩状态（第38-39行）
void TearDown() override
{
    ut_enableNetworkByDBus_ret = false;
    ut_enableNetworkByDBus_calls = 0;
    ut_enableNetworkByDBus_args.clear();
    ut_enableNetworkByIoctl_ret = false;
    ut_enableNetworkByIoctl_calls = 0;
    ut_ioctlOperate_ret = false;
    ut_ioctlOperate_calls = 0;
    ut_ioctlOperate_args.clear();
    ut_isSafeSysfs_ret = false;
    ut_isSafeSysfs_calls = 0;
    ut_ifaceValid_ret = false;
    ut_ifaceValid_calls = 0;
    ut_ifaceValid_seq.clear();
    ut_doCall_calls = 0;
    ut_doCall_seq.clear();
    ut_qfileOpen_ret = false;
    ut_qfileOpen_calls = 0;
    ut_qfileWrites.clear();
    ut_qfileExists_ret = false;
    ut_qfileExists_calls = 0;
    ut_socket_fd = -1;
    ut_socketOpen_calls = 0;
    ut_ioctlGiFlags_ret = 0;
    ut_ioctlSiFlags_ret = 0;
    ut_ioctlSiFlags_seen = -1;
}

---

本报告由 AI 代码审查工具自动生成

[add-uos]

关闭重复 PR：此 PR 基于 PR #937 合入前的 master，diff 中包含测试文件整体新增改动，与当前 master 冲突。已基于最新 master 重新提交干净 PR #954（仅含 enableutils.cpp 源码修复）。