Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds null checks around three previously unsafe DStyle casts, preserving device-list and log-header rendering with default margin/radius values and warnings in non-DStyle environments while leaving normal DStyle behavior unchanged. Flow diagram for safe DStyle metric fallbackflowchart TD
A["View rendering requests style metric"] --> B["dynamic_cast<DStyle *>(DApplication::style())"]
B --> C{style available?}
C -->|Yes| D["pixelMetric(PM_ContentsMargins or PM_FrameRadius)"]
C -->|No| E["Use default margin=10 or radius=8"]
E --> F["qCWarning(appLog)"]
D --> G["Continue rendering or sizing"]
F --> G
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 语法正确，逻辑清晰 ✅ 通过 潜在问题： 建议： [] 2. 代码质量 ✅评价： 代码结构清晰，注释完整 ✅ 通过 潜在问题： 建议： ["将版权头统一修改为 '// Copyright (C) 2019-2026 UnionTech Software Technology Co.,Ltd' 或 '// Copyright (C) 2019 ~ 2026 UnionTech Software Technology Co.,Ltd'"] 3. 代码性能 ✅评价： 性能良好，资源使用合理 ✅ 通过 潜在问题： 建议： [] 4. 代码安全 🔒评价： 存在0个安全漏洞 ✅ 通过
安全漏洞详情： 建议： [] 💡 改进建议代码示例// 修复版权头格式（以 DriverListView.cpp 为例）： // 修改前： // Copyright (C) 2019-2026 ~ 2020 UnionTech Software Technology Co.,Ltd // // 修改后： // Copyright (C) 2019-2026 UnionTech Software Technology Co.,Ltd本报告由 AI 代码审查工具自动生成 |
1. dynamic_cast<DStyle*>(DApplication::style()) return value was dereferenced without null check, causing SIGSEGV when the app style is not a DStyle derivative 2. Add null check with fallback default values (margin=10, radius=8) in paint(), drawRow() and sectionSizeHint() to prevent crash 3. Emit qCWarning(appLog) when style is null for diagnostics 4. Consistent with the 11 existing null-check guards in the codebase Log: fix potential crash in non-DStyle style environments Influence: 1. Verify device list view renders correctly under DStyle environment 2. Verify no crash when running under non-DStyle (e.g. QApplication) environment 3. Verify log view header sizing is correct fix: 修复视图控件中 DStyle 转换未判空导致的崩溃 1. dynamic_cast<DStyle*>(DApplication::style()) 返回值未判空即解引用， 非派生自 DStyle 的样式环境下导致段错误 2. 在 paint()、drawRow()、sectionSizeHint() 中添加判空并回退默认值 (margin=10, radius=8)，防止崩溃 3. style 为空时输出 qCWarning(appLog) 日志便于排查 4. 与代码库中已有 11 处判空保护模式风格统一 Log: 修复非 DStyle 样式环境下的潜在崩溃问题 Influence: 1. 验证 DStyle 环境下设备列表视图渲染正常 2. 验证非 DStyle 环境（如 QApplication）下不崩溃 3. 验证日志视图表头尺寸计算正确
The license-check CI (SPDX Header Validation) requires the copyright year range of touched sources to end with the current year. Extend the legacy copyright headers of DriverListView.cpp and DriverListViewDelegate.cpp (2019 ~ 2020) so 2026 is covered and the SPDX summary reports 0 failures.
add-uos
force-pushed
the
agent/bug/de73d8bfece7
branch
from
October 27, 2026 03:45
5d05863 to
71a335e
Compare
Contributor
|
TAG Bot New tag: 6.0.75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause Analysis
dynamic_cast<DStyle*>(DApplication::style())return value was dereferenced without null check inDriverListViewDelegate::paint(),DriverListView::drawRow(), andLogViewHeaderView::sectionSizeHint(). When the application style is not a DStyle derivative (e.g. QApplication embedding or third-party style), the cast returns nullptr, causing SIGSEGV on every item paint. The codebase has 14 such cast sites; 11 already have null guards, these 3 were missed.Fix Approach
Add null check before dereferencing the DStyle pointer in all 3 locations. When style is null, fall back to default values (margin=10, radius=8) and emit a qCWarning diagnostic log. This preserves rendering continuity in non-DStyle environments rather than early-returning, which would skip item drawing entirely.
Change Safety Assessment
Code Safety
Business Impact Scope
Affects device list view rendering, log view header sizing, and row drawing in the device manager UI. In normal DStyle environments, behavior is unchanged. In non-DStyle environments (unit test, QApplication embedding), crashes are prevented and UI renders with fallback values.
Verification Suggestion
Verify device list view and log view render correctly under normal DStyle environment (no regression). Optionally test under QApplication-only environment to confirm no crash.
根因分析
DriverListViewDelegate::paint()、DriverListView::drawRow()和LogViewHeaderView::sectionSizeHint()中dynamic_cast<DStyle*>(DApplication::style())返回值未判空即解引用。当应用样式非 DStyle 派生（如 QApplication 嵌入或第三方样式）时，cast 返回 nullptr，每次条目绘制即段错误。代码库共 14 处同类调用，11 处已有判空保护，此 3 处为遗漏。修复方案
在 3 处添加 DStyle 指针判空，为空时回退默认值（margin=10, radius=8）并输出 qCWarning 诊断日志。回退默认值而非早期 return，以保证非 DStyle 环境下渲染连续性。
改动安全评估
代码安全评估
业务影响范围
影响设备管理器中设备列表视图渲染、日志视图表头尺寸计算和行绘制。正常 DStyle 环境下行为不变。非 DStyle 环境（单元测试、QApplication 嵌入）下可防止崩溃并以默认值渲染。
验证建议
验证 DStyle 环境下设备列表视图和日志视图渲染正常（无回归）。可选测试 QApplication-only 环境确认不崩溃。
Summary by Sourcery
Prevent view rendering crashes in non-DStyle environments while preserving normal DStyle behavior.
Bug Fixes:
Enhancements: