Skip to content

chore(i18n): add PreLoginWindow source text for user notice - #461

Open
yixinshark wants to merge 1 commit into
linuxdeepin:masterfrom
yixinshark:chore/i18n-user-notice
Open

yixinshark wants to merge 1 commit into
linuxdeepin:masterfrom
yixinshark:chore/i18n-user-notice

Conversation

@yixinshark

@yixinshark yixinshark commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Add the PreLoginWindow context to all translation files so that the "OK" button of the pre-login user notice can be translated.\n\nOnly the source text is added, translations are left empty for the translation platform to fill in. Existing entries and their line numbers are kept untouched.\n\nPMS: TASK-396167

Summary by Sourcery

Enhancements:

  • Add the PreLoginWindow “OK” source entry to all session UI translation catalogs so the pre-login user notice can be localized.

Add the PreLoginWindow context to all translation files so that the
"OK" button of the pre-login user notice can be translated. Only the
source text is added, translations are left empty for the translation
platform to fill in.

PMS: TASK-396167
Log:
Change-Id: Idbe4cd6c4301dd76c1016d024914f63f09ab8758
@sourcery-ai

sourcery-ai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Reviewer's Guide

All session UI translation files now include the PreLoginWindow/OK source entry, enabling the pre-login user notice button to be localized while preserving existing catalog entries and line numbers.

File-Level Changes

Change Details Files
Register the pre-login notice’s OK button in every session UI translation catalog.
  • Added a PreLoginWindow context with the source string OK.
  • Recorded the source location in preLoginWindow.cpp at line 58.
  • Left all new translations unfinished for later localization.
translations/dde-session-ui*.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交为 i18n 翻译文件更新,为 PreLoginWindow 类添加 OK 按钮的翻译源文本到 30 个 .ts 翻译文件中。所有变更均为标准的 Qt 翻译文件 XML 格式新增,无安全漏洞,四维度均通过。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: ['建议在 dde-session-ui_sk.ts 中将新增的 改为自闭合形式 ,与该文件既有风格保持一致']


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例


本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants