Skip to content

sync: from linuxdeepin/dde-session-shell - #557

Open
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-103-nosync
Open

deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-103-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#103

Summary by Sourcery

Fix inhibitor warning icons so executable-based icon resolution is retained correctly.

Bug Fixes:

  • Preserve the resolved executable icon name when determining inhibitor application icons.

Chores:

  • Update the copyright year in the affected widget source file.

@sourcery-ai

sourcery-ai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fix icon-name handling in inhibitor warnings by assigning the executable filename to the existing variable, preventing local shadowing and ensuring the resolved name is used for themed icon lookup.

File-Level Changes

Change Details Files
Preserve the existing icon name while deriving an executable-based fallback icon.
  • Remove the local redeclaration so the surrounding icon-name state is updated rather than shadowed.
  • Continue using the executable filename to resolve the themed icon, including containerized application paths.
src/widgets/inhibitwarnview.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#103
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次变更是一个从 dde-session-shell 同步过来的修复提交,仅修改 inhibitwarnview.cpp 中的 2 行代码。 主要修复了 InhibitWarnView::setInhibitorList 函数中的变量遮蔽(variable shadowing)问题: 原代码在 if 块内部重新声明了局部变量 QString iconName,导致对 executable_info.fileName() 的赋值仅修改了内层局部变量, 而未影响外层作用域中实际被 QIcon::fromTheme(iconName) 使用的同名变量。 去掉 QString 声明后,赋值正确写入外层 iconName 变量,修复了图标可能显示不正确的 Bug。 另一处变更是 SPDX 版权年份从 2022 更新至 2026,属常规维护。四维度均无问题,无安全漏洞。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 无


💡 改进建议代码示例

// 修复后的代码(当前提交已正确修复,无需额外改动):
// inhibitwarnview.cpp - InhibitWarnView::setInhibitorList
// 去掉 QString 声明,赋值写入外层作用域的 iconName 变量
iconName = executable_info.fileName();

本报告由 AI 代码审查工具自动生成

@Ivy233

Ivy233 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

linuxdeepin/dde-session-shell#103 ,镜像PR已过,因此该PR也Approve。

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, Ivy233

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants