Repository navigation
sync: from linuxdeepin/dde-session-shell - #553
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#101
Reviewer's GuideSynchronizes the Mongolian translation catalog from dde-session-shell by replacing unfinished entries with completed translations across authentication and session-shell UI flows, while retaining pluralization structures and runtime placeholders. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="translations/dde-session-shell_mn.ts" line_range="6" />
<code_context>
<message>
<source>Face ID</source>
- <translation type="unfinished"/>
+ <translation>Царайны ID</translation>
</message>
<message>
</code_context>
<issue_to_address>
**Mongolian strings remain untranslated**
When the system or user locale is `mn_MN` or `mn_MN.UTF-8`, `loadTranslation()` keeps the region and looks for `dde-session-shell_mn_MN.qm`, but this PR adds only the catalog compiled from `dde-session-shell_mn.ts`, so the catalog fails to load and users see untranslated source strings.
Make `loadTranslation()` fall back to the language-only `mn` catalog when no regional catalog exists.
</issue_to_address>| <message> | ||
| <source>Face ID</source> | ||
| <translation type="unfinished"/> | ||
| <translation>Царайны ID</translation> |
There was a problem hiding this comment.
🟡 Medium · Mongolian strings remain untranslated
When the system or user locale is mn_MN or mn_MN.UTF-8, loadTranslation() keeps the region and looks for dde-session-shell_mn_MN.qm, but this PR adds only the catalog compiled from dde-session-shell_mn.ts, so the catalog fails to load and users see untranslated source strings.
Make loadTranslation() fall back to the language-only mn catalog when no regional catalog exists.
Prompt for AI agents
In `translations/dde-session-shell_mn.ts` at line 6:
**Mongolian strings remain untranslated**
When the system or user locale is `mn_MN` or `mn_MN.UTF-8`, `loadTranslation()` keeps the region and looks for `dde-session-shell_mn_MN.qm`, but this PR adds only the catalog compiled from `dde-session-shell_mn.ts`, so the catalog fails to load and users see untranslated source strings.
Make `loadTranslation()` fall back to the language-only `mn` catalog when no regional catalog exists.|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#101
Summary by Sourcery
Enhancements: