Skip to content

sync: from linuxdeepin/dde-session-shell - #553

Merged
BLumia merged 1 commit into
masterfrom
sync-pr-101-nosync
Oct 14, 2026
Merged

BLumia merged 1 commit into
masterfrom
sync-pr-101-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#101

Summary by Sourcery

Enhancements:

  • Complete Mongolian translations for authentication, session management, power operations, account selection, updates, networking, and related system interface messages.

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#101
@sourcery-ai

sourcery-ai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Reviewer's Guide

Synchronizes the Mongolian translation catalog from dde-session-shell by replacing unfinished entries with completed translations across authentication and session-shell UI flows, while retaining pluralization structures and runtime placeholders.

File-Level Changes

Change Details Files
Complete the Mongolian localization for authentication, session, power-management, account, update, and warning UI strings.
  • Replace unfinished translations with Mongolian text across authentication contexts, including face, fingerprint, iris, passkey, password, UKey, and password-expiry messages.
  • Add Mongolian translations for login/account selection, session mode, lock-screen, shutdown/reboot/logout, update, network, and automatic-login strings.
  • Populate Mongolian translations for MFA phone-number and verification-code prompts, preserving Qt plural forms and %n placeholders.
translations/dde-session-shell_mn.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="translations/dde-session-shell_mn.ts" line_range="6" />
<code_context>
     <message>
         <source>Face ID</source>
-        <translation type="unfinished"/>
+        <translation>Царайны ID</translation>
     </message>
     <message>
</code_context>
<issue_to_address>
**Mongolian strings remain untranslated**

When the system or user locale is `mn_MN` or `mn_MN.UTF-8`, `loadTranslation()` keeps the region and looks for `dde-session-shell_mn_MN.qm`, but this PR adds only the catalog compiled from `dde-session-shell_mn.ts`, so the catalog fails to load and users see untranslated source strings.

Make `loadTranslation()` fall back to the language-only `mn` catalog when no regional catalog exists.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

<message>
<source>Face ID</source>
<translation type="unfinished"/>
<translation>Царайны ID</translation>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Mongolian strings remain untranslated

When the system or user locale is mn_MN or mn_MN.UTF-8, loadTranslation() keeps the region and looks for dde-session-shell_mn_MN.qm, but this PR adds only the catalog compiled from dde-session-shell_mn.ts, so the catalog fails to load and users see untranslated source strings.

Make loadTranslation() fall back to the language-only mn catalog when no regional catalog exists.

Prompt for AI agents
In `translations/dde-session-shell_mn.ts` at line 6:

**Mongolian strings remain untranslated**

When the system or user locale is `mn_MN` or `mn_MN.UTF-8`, `loadTranslation()` keeps the region and looks for `dde-session-shell_mn_MN.qm`, but this PR adds only the catalog compiled from `dde-session-shell_mn.ts`, so the catalog fails to load and users see untranslated source strings.

Make `loadTranslation()` fall back to the language-only `mn` catalog when no regional catalog exists.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit 4d32363 into master Oct 14, 2026
24 of 27 checks passed
@BLumia
BLumia deleted the sync-pr-101-nosync branch October 14, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants