Repository navigation
fix: migrate VPN backend disable logic from network-manager-integration-plugins - #641
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR restores the VPN backend service-disable logic lost when the dependency was replaced, by adding a dcc-network-plugin post-install script that disables ipsec, xl2tpd, and openvpn on installation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
mhduiy
reviewed
Oct 15, 2026
…on-plugins The postinst from network-manager-integration-plugins (0.0.5-0deepin) was not migrated when its dependency was replaced with direct NM plugin deps in 581b0c6, leaving ipsec/xl2tpd/openvpn init.d services enabled on fresh installs. fix: 迁移 network-manager-integration-plugins 的 VPN 后端禁用逻辑 581b0c6 移除 network-manager-integration-plugins 依赖时未迁移其 postinst 的 VPN 后端禁用逻辑，导致 ipsec/xl2tpd/openvpn 的 init.d 服务保持启用。 本提交将 postinst 原样迁移到 dcc-network-plugin，安装时自动禁用这三个服务。 Log: 迁移 VPN 后端禁用逻辑到 dcc-network-plugin PMS: BUG-379501 Influence: 安装 dcc-network-plugin 后首次配置会禁用 ipsec/xl2tpd/openvpn 的 init.d 服务，由 NetworkManager 统一管理 VPN 后端，避免重复自启。
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅
分析：
潜在问题： 2. 代码质量 ✅
分析：
潜在问题：
建议：
3. 代码性能 ✅
分析：
潜在问题： 4. 代码安全 🔒
分析：
安全漏洞详情： 漏洞对比统计： 新增漏洞 0 个，减少漏洞 0 个，持平 0 个 建议： 💡 改进建议代码示例#!/bin/sh
# Disable the network manager plugin backend service.
# NetworkManager will start service automatically.
# Disable ipsec/xl2tpd/openvpn init.d services to avoid duplicate startup,
# as NetworkManager manages VPN backends centrally.
if [ ! -e /var/cache/deepin/mark-setup-network-services ]; then
update-rc.d ipsec disable || true
update-rc.d xl2tpd disable || true
update-rc.d openvpn disable || true
mkdir -p /var/cache/deepin
touch /var/cache/deepin/mark-setup-network-services
fi
#DEBHELPER#
exit 0📋 审查清单
本报告由 AI 代码审查工具自动生成 |
mhduiy
approved these changes
Oct 15, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The postinst from network-manager-integration-plugins (0.0.5-0deepin) was not migrated when its dependency was replaced with direct NM plugin deps in 581b0c6, leaving ipsec/xl2tpd/openvpn init.d services enabled on fresh installs.
fix: 迁移 network-manager-integration-plugins 的 VPN 后端禁用逻辑
581b0c6 移除 network-manager-integration-plugins 依赖时未迁移其 postinst 的 VPN 后端禁用逻辑，导致 ipsec/xl2tpd/openvpn 的 init.d 服务保持启用。 本提交将 postinst 原样迁移到 dcc-network-plugin，安装时自动禁用这三个服务。
Log: 迁移 VPN 后端禁用逻辑到 dcc-network-plugin
PMS: BUG-379501
Influence: 安装 dcc-network-plugin 后首次配置会禁用 ipsec/xl2tpd/openvpn 的 init.d 服务，由 NetworkManager 统一管理 VPN 后端，避免重复自启。
Summary by Sourcery
Bug Fixes: