Skip to content

fix: set Xorg fake screen refresh rate to 30 Hz - #1288

Open
zorowk wants to merge 1 commit into
linuxdeepin:masterfrom
zorowk:fix_refresh
Open

zorowk wants to merge 1 commit into
linuxdeepin:masterfrom
zorowk:fix_refresh

Conversation

@zorowk

@zorowk zorowk commented Oct 27, 2026 •

Copy link
Copy Markdown

快速熄屏唤醒时,Xorg 的低频模拟 vblank 可能延迟帧完成通知,导致先显示桌面再显示锁屏。

  • 在 LightDM 的 Xorg 启动命令中加入 -fakescreenfps 30,将模拟刷新频率设为 30 Hz。

缩短模拟刷新计数对应的等待周期,缓解快速唤醒时锁屏显示迟到的问题。

PMS: BUG-378549

Summary by Sourcery

Bug Fixes:

  • Set the Xorg fake screen refresh rate to 30 Hz to reduce delayed frame notifications during rapid screen wake-up and prevent the desktop from appearing before the lock screen.

快速熄屏唤醒时,Xorg 的低频模拟 vblank 可能延迟帧完成通知,导致先显示桌面再显示锁屏。

- 在 LightDM 的 Xorg 启动命令中加入 -fakescreenfps 30,将模拟刷新频率设为 30 Hz。

缩短模拟刷新计数对应的等待周期,缓解快速唤醒时锁屏显示迟到的问题。

PMS: BUG-378549
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zorowk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

LightDM now starts Xorg with a 30 Hz fake screen refresh rate, shortening simulated vblank intervals to help ensure the lock screen appears before the desktop during rapid wake-up.

Sequence diagram for 30 Hz fake screen refresh during wake-up

sequenceDiagram
    participant LightDM
    participant Xorg
    participant LockScreen
    participant Desktop
    LightDM->>Xorg: start with -fakescreenfps 30
    Xorg-->>LockScreen: simulated vblank notifications at 30 Hz
    LockScreen->>Xorg: render lock screen
    Xorg-->>Desktop: frame completion notification
    Note over LockScreen,Desktop: Lock screen is displayed before the desktop
Loading

File-Level Changes

Change Details Files
Configure Xorg’s simulated screen refresh rate to reduce lock-screen display latency during rapid screen-off wake-up.
  • Add the -fakescreenfps 30 option to the LightDM Xorg startup command.
  • Set the fake vblank cadence to 30 Hz so frame-completion notifications arrive sooner and more consistently.
misc/lightdm.conf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交在 misc/lightdm.conf 中为 Xorg 命令添加 -fakescreenfps 30 参数, 将假屏刷新率设置为 30 Hz。变更仅一行配置,语法正确,逻辑清晰, 无安全漏洞,无性能问题,代码质量良好。启发式扫描与 OCR 审查均未发现问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 无


💡 改进建议代码示例

# 当前配置已正确,无需修改 # misc/lightdm.conf [Seat:*] xserver-command=X -background none -fakescreenfps 30 greeter-session=lightdm-deepin-greeter user-session=deepin

本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants