Fix several issues with oneof responses - #924
Open
ezilber-akamai wants to merge 4 commits into
Open
Conversation
ezilber-akamai
added
the
hotfix
ezilber-akamai
requested review from
jriddle-linode and
mawilk90
and removed request for
a team
September 9, 2026 15:16
ezilber-akamai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixed
oneOfresponse properties being overwritten during schema aggregation. When aoneOfdefines the same property across multiple branches, keep the most complete definition instead of letting a later, emptier branch overwrite it. This fixes fields likepublic.ipv6.rangesbeing dropped from output.Also fixed an issue with oneOf schemas in
_parse_response_modelthat was causing nested response data to be displayed incorrectly.✔️ How to Test
make test-unitmake test-int TEST_CASE=test_interface_update(was previously failing)make test-int TEST_SUITE=firewalls(was previously failing)