Repository navigation
fix(native-tools): extract in projects with jsxRuntime "vue" - #291
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 11 11
Lines 2576 2576
=======================================
Hits 2437 2437
Misses 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
`createSwcExtractor()` passed `macro.jsxRuntime` from the Lingui config to the native extractor, which only knows "react" and "solid". With `@lingui/vue/config` every file failed with `unknown variant vue`. `jsxRuntime` never changes the extracted messages, so drop it for extraction. Fixes #289 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrii-bodnar
force-pushed
the
fix/extractor-jsx-runtime-vue
branch
from
November 4, 2026 08:47
642a6e8 to
e7ccf5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lingui/vue/configsetsmacro.jsxRuntime: "vue".createSwcExtractor()passed it to the native extractor, which only knows"react"and"solid", so extraction failed on every file:jsxRuntimeonly changes how<Trans>children are emitted, never the extracted messages. The extractor now leaves it out. The nativetransform()still rejects"vue", as before.Tests: new
createSwcExtractortest withjsxRuntime: "vue". It fails without the fix and passes with it. The rest of the native-tools suite passes.Fixes #289
🤖 Generated with Claude Code