Skip to content

close the 400 and 423 error details to their declared fields #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreyav wants to merge 3 commits into
base: main
Choose a base branch
from
Open

close the 400 and 423 error details to their declared fields #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cd5a1b
say where a provider-account selection error lists the candidates
shreyav Sep 14, 2026
f2e28e3
close the 400 and 423 error details to their declared fields
shreyav Sep 15, 2026
3364375
keep the selection-required row as it was
shreyav Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions openapi/components/schemas/errors/Error400.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,10 @@ properties:
details:
type: object
description: >-
Additional error details. Shape varies by `code`. For field-validation
errors on submit endpoints (e.g. `POST /customers`, `PATCH /customers/{id}`),
`details.errors[]` enumerates every invalid field so platforms can render
form-field-level UX for the entire request in a single round-trip.
Field-level detail. On field-validation errors from submit endpoints
(e.g. `POST /customers`, `PATCH /customers/{id}`), `details.errors[]`
enumerates every invalid field so platforms can render form-field-level
UX for the entire request in a single round-trip.
properties:
errors:
type: array
Expand All @@ -147,4 +147,3 @@ properties:
submit endpoints.
Comment on lines 137 to 147

@greptile-apps greptile-apps Bot Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Details Objects Remain Open

Removing additionalProperties: true does not close this object. The contract uses OpenAPI 3.1, where omitting additionalProperties still permits undeclared fields. As a result, the Error400 details object—and the same object in Error423—remains open, so the intended generated-client contract is not established. Declare additionalProperties: false on both objects.

Knowledge Base Used: Grid API contract

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/errors/Error400.yaml
Line: 137-147

Comment:
**Details Objects Remain Open**

Removing `additionalProperties: true` does not close this object. The contract uses OpenAPI 3.1, where omitting `additionalProperties` still permits undeclared fields. As a result, the Error400 `details` object—and the same object in Error423—remains open, so the intended generated-client contract is not established. Declare `additionalProperties: false` on both objects.

**Knowledge Base Used:** [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

items:
$ref: ./FieldError.yaml
additionalProperties: true
1 change: 0 additions & 1 deletion openapi/components/schemas/errors/Error423.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,3 @@ properties:
format: date-time
failedAttempts:
type: integer
additionalProperties: true
Loading