Describe platformCardId as caller-suppliable with a system-generated fallback - #1022
ls-bolt[bot] wants to merge 1 commit into
Conversation
…fallback The create-card description said the value was always server-generated and any supplied value ignored. Match the platformCustomerId wording on CustomerCreateRequest instead: optional, system-generated when omitted. Co-Authored-By: aaryamanbhute <aaryamanbhute@users.noreply.github.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@greptile review |
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-python studio · code · diff
✅ grid-php studio · code · diff
✅ grid-cli studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
|
| |-------|----------|-------| | ||
| | `customerId` | Yes | The `Customer` that owns the card. Must be `kycStatus: APPROVED`. | | ||
| | `platformCardId` | No | Ignored if supplied. The value on the returned `Card` is generated by the server. | | ||
| | `platformCardId` | No | Your own identifier for the card. Generated by the system if you omit it. | |
There was a problem hiding this comment.
When a caller supplies platformCardId, this text promises that it becomes their identifier for the card. Card issuance currently ignores that value and returns a generated one, while the card-list API supports filtering by platformCardId. A caller following this guide can therefore fail to find or correlate the created card using the identifier they supplied. This violates the repository directive to prioritize accurate, usable documentation; the docs need to describe the current behavior until the API honors caller-supplied values.
Context Used: mintlify/AGENTS.md (source)
Knowledge Base Used: Cards API
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/cards/issuing-cards.mdx
Line: 24
Comment:
**Caller identifier is ignored**
When a caller supplies `platformCardId`, this text promises that it becomes their identifier for the card. Card issuance currently ignores that value and returns a generated one, while the card-list API supports filtering by `platformCardId`. A caller following this guide can therefore fail to find or correlate the created card using the identifier they supplied. This violates the repository directive to prioritize accurate, usable documentation; the docs need to describe the current behavior until the API honors caller-supplied values.
**Context Used:** mintlify/AGENTS.md ([source](https://github.com/lightsparkdev/grid-api/blob/main/mintlify/AGENTS.md))
**Knowledge Base Used:** [Cards API](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/cards-api.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
CardCreateRequest.platformCardIdwas described as "Always generated by the server; any value supplied in the request is ignored." This PR replaces that with the wording already used for the equivalent field onCustomerCreateRequest:The two cards guides that carried the same "ignored if supplied" framing are updated to match, and
Card.platformCardIddrops its "generated by the server" qualifier so the response description reads like every other platform-id field on a resource.Note for reviewers
This describes the intended contract for the field. Card issuance today still assigns its own value and returns that on the created
Card, so a caller who suppliesplatformCardIdcannot yet retrieve or filter by the value they chose — support for honoring a caller-supplied id is a separate change. Merging this ahead of that work is a deliberate choice to match the documented contract customers have been given; reverting to the previous text is a one-line change if the preference is to wait.Changes: 6 files
openapi/components/schemas/cards/CardCreateRequest.yaml— newplatformCardIddescriptionopenapi/components/schemas/cards/Card.yaml— response description drops "generated by the server"mintlify/snippets/cards/issuing-cards.mdx— request-field table rowmintlify/snippets/cards/quickstart.mdx— issuance walkthrough sentenceopenapi.yaml,mintlify/openapi.yaml— regenerated bundles (make build)Test plan
Docs-only repo, no application code.
make build— bundles regenerated; the bundle diff is exactly the two description linesmake lint— exit 0,0 errors, warning/info counts unchanged from baselineany value supplied in the request is ignored,Ignored if supplied) — no remaining occurrences in specs, snippets, SDKs, or samplesRequested by @AaryamanBhute