Repository navigation
fix: send OpenAI developer and list-content system messages as Gemini systemInstruction - #152
Merged
lich0821 merged 1 commit intoOct 27, 2026
Conversation
… systemInstruction Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAIReqToGeminionly treated a message withrole: "system"and a plain string as a system instruction. Two inputs that OpenAI clients send went wrong:developermessage (the role newer OpenAI clients use for instructions) was not recognised, so it was put incontentswithrole: "developer", which Gemini does not accept (onlyuserandmodel).systemmessage whose content is a list of text parts ([{"type": "text", "text": ...}]) was dropped silently, because only string content was read.Both roles now go through
extractSystemText(already used for Claude system prompts, it reads a string or a list of text parts) and are joined, in order, intosystemInstruction. Requests with a plainsystemstring produce the same output as before.Tests:
openai_gemini_system_test.gocovers adeveloperstring, asystemlist of parts, and a mix of both in order, and checks thatcontentsonly carriesuserandmodel; all three fail onmaster.go vetandgo test ./internal/...pass. Not run against the live Gemini API.This change was prepared with AI assistance (Claude Code).