Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AirPods can be connected for audio while LibrePods fails to establish its control connection. If BlueZ reports
Connectedbefore its UUID list is populated, the monitor ignores the device and does not reconsider it whenUUIDsorServicesResolvedchanges. The fallback inconnectToAirPods()also cannot identify any device: it constructs aQBluetoothDeviceInfofrom an address without loading its service UUIDs, then searches that empty list for the AirPods UUID.This change rechecks BlueZ device properties after connection and service-discovery updates and uses the same BlueZ enumeration for explicit retries. It remembers announced devices to avoid duplicate connection notifications and to handle disconnection even after BlueZ clears their UUIDs. It also avoids invoking
bluetoothctl connectwithout a known address. The unused startup fallback is removed; the existing monitor callback already handles A2DP activation.The monitor no longer scans from its constructor, before its consumer has connected the signals. The existing explicit startup scan in
AirPodsTrayAppremains. An optional D-Bus connection argument lets the regression tests use a disconnected connection without accessing the host Bluetooth service.Validation:
librepods-ctlbuild passed with GCC 16.2.1 and Qt 6.12.0.ctest --test-dir build --output-on-failurepassed.git diff --checkpassed.Build and test:
Prepared against
mainat89356c08(also taggedv1.0.4), confirmed by fetching upstream before submission.Checked all 112 open upstream PRs for overlapping changes before submission. Related PR #892 restricts D-Bus signal admission, while #518 changes L2CAP transport; neither addresses the delayed service-discovery handling or empty-UUID fallback fixed here.