Add timeout-minutes to jobs that have none (PM_GH_REPO_024) - #217
Open
anish-sujanani wants to merge 1 commit into
Open
anish-sujanani wants to merge 1 commit into
anish-sujanani wants to merge 1 commit into
Conversation
Sized from observed per-job durations of successful runs where available, otherwise from a budget the job itself declares or from what the steps do. Cancelled and failed runs were excluded. See the batch notes for per-job reasoning.
There was a problem hiding this comment.
Adds timeout-minutes to the two jobs that lacked it. Values look sane: the aggregation-only all-checks job gets 3 minutes, and the Docker build gets 20 against a 7.7m observed max. No correctness or security concerns; nothing else in the workflows moved.
Review Scope
- Mode: Full pull request
- Range:
Full pull request through 1692f19afebec0e6e4d837f53582a3315fdfc6c6 - Current range coverage: Complete
- Cumulative pull request coverage: Complete
This review is complete for the current scope. Addressing all critical and warning findings above satisfies the review; suggestions are optional. Request another review only if subsequent changes introduce new behavior or materially expand the pull request's scope.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
timeout-minutesto jobs that have noneAddresses PM_GH_REPO_024 — Workflow jobs must declare a timeout.
A job with no
timeout-minutesinherits GitHub's default of 360 minutes, so a hung jobholds a runner for six hours before the platform stops it. This bounds 2 jobs;
worst case for this repo drops from 720 runner-minutes to 23.
Proposed values
timeout-minutesci.ymlall-checksdocker-build.ymlbuildHow these were calculated
GET /repos/{owner}/{repo}/actions/runs/{id}/jobs, per-jobstarted_attocompleted_atover the 50 most recent completed runs of each workflow. That is the sameclock
timeout-minutesuses: it starts when the job begins executing and excludes queueand runner-acquisition time, so it will read lower than the run duration shown in the
Actions tab.
cancel or when a job died, not how long the work takes.
suite. A 3-minute floor killed a legitimate job in CI earlier in this rollout.
Verification
timeout-minutesstripped from bothtrees, so nothing else moved.
timeout-minutes:lines and deletes nothing.actionlintreports the same findings before and after.Break risk
A timeout can only stop a job that exceeds it. If any value is tighter than you want, say so
and I will raise it — a loose bound still fixes the finding.