test(packages): typecheck the packed packages with TypeScript 5 too - #102
Merged
Merged
Conversation
The workspace now builds declarations with TypeScript 7, while most applications still compile with TypeScript 5. The packed-package consumer typechecks its browser and worker imports with both, so a declaration only TypeScript 7 accepts fails CI before release. Signed-off-by: Wondertan <hlibwondertan@gmail.com> Assisted-by: Claude Opus 5.5
Wondertan
force-pushed
the
test/typescript-5-consumer
branch
from
October 2, 2026 18:41
c98e099 to
6e0229a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace now builds declarations with TypeScript 7 (#58), but most applications still compile with TypeScript 5.
test:packagesinstallstypescript@^5next to the workspace compiler in the isolated consumer, and typechecks the browser and worker imports with both, so a declaration only TypeScript 7 accepts fails CI before any release. Today TypeScript 5.9.3 accepts all three packages' declarations.