Skip to content

fix(core): run the skill-digester helper as CommonJS - #380

Merged
qorzj merged 1 commit into
lessweb:mainfrom
xiaofeilovecoding:fix/skill-digester-commonjs
Oct 23, 2026
Merged

qorzj merged 1 commit into
lessweb:mainfrom
xiaofeilovecoding:fix/skill-digester-commonjs

Conversation

@xiaofeilovecoding

Copy link
Copy Markdown

Summary

  • Rename the bundled helper to .cjs so it works inside both ESM and CommonJS projects.
  • Update the documented commands and add subprocess regressions for both package scopes.

Fixes #374

Validation

Validated on Windows with Node 24.18.0:

  • npm run check
  • All workspace suites: 794 passed, 12 skipped
  • Core/CLI and VSCode builds
  • Packaged CLI helper with real gray-matter parsing

Use an explicit .cjs entry point so bundled and project-installed skills
work under both ESM and CommonJS package scopes. Keep the documented
invocation synchronized and cover actual skill lookup in subprocess tests.

Fixes lessweb#374
@qorzj
qorzj merged commit 40dbb8b into lessweb:main Oct 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] bundled skill-digester/scripts/find-skill.js crashes: "require is not defined in ES module scope"

2 participants