Repository navigation
feat: let WordPress and Bedrock run lerd's wp-cli without composer - #107
Merged
Merged
Conversation
WordPress 5, 6 and 7 and Bedrock 1 name lerd's wp-cli tool under vendor_bin_tools, so lerd wp works on a site that never installed wp-cli through composer. Binaries that predate the key ignore it. The CLI ini also sends PHP's notices to stderr and leaves out its own deprecations. The wp-cli 2.12.0 phar bundles code PHP 8.5 deprecates, and without this every lerd wp on 8.5 printed a notice into stdout, which broke piped output such as a database export. Refs lerd-env/lerd#1744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress 5, 6 and 7 and Bedrock 1 name lerd's wp-cli tool under vendor_bin_tools, so lerd wp works on a site that never installed wp-cli through composer. lerd fetches the pinned wp-cli release on first use and lists it on the Tools page, which lands with lerd-env/lerd#2511.
The CLI ini also sends PHP's notices to stderr and leaves out its own deprecations. The wp-cli 2.12.0 phar bundles code PHP 8.5 deprecates, and without this every lerd wp on 8.5 printed a notice into stdout, which broke piped output such as a database export.
Binaries that predate vendor_bin_tools ignore it and keep behaving as they do today, while the ini change already applies to them. Even so, this is best merged once #2511 is in a release, so the key does something the day it reaches installs.
Refs lerd-env/lerd#1744