Repository navigation
fix(compat): replace deprecated Kit 3 lib alias - #597
Conversation
|
Review of PR #597 — two merge blockers (head GitHub Actions CI #587 passed its required quality job (full root tests, lint, typecheck, manifest freshness, build-all). The documented Kit 2 BLOCKER 1 — Preserve unrelated package imports without silently breaking conflicting In Correction: preserve unrelated consumer import entries, detect any conflicting BLOCKER 2 — Do not assume any
Correction: inspect whether After fixes, rerun the config/consumer tests, relevant generated Base/Dashboard smoke, and required CI on the new commit. No need to expand into the documented, pre-existing Kit 2 hook types issue or to publish packages. MERGE DECISION: DO NOT MERGE. |
|
Both blockers are fixed in
Validation passed: |
|
CI has completed on |
|
Follow-up review of PR #597 at
MERGE DECISION: READY TO MERGE. |
Summary
$libimports with explicit-extension#libpackage subpaths across SVForge templates and add-ons; preserve existing packageimportsentries and recognize legacy imports for add-on patch idempotency.sveltekit({ alias })option. Update Vitest resolution while keeping$libavailable as a Kit 2 test fallback.Validation
bun run test— 121 files, 1,188 tests passed.bun run lint,bun run typecheck,bun run build:all— passed.sv addand packedsvforge createjourneys passed./logindev smoke. The Vite dev log had noconfig_option_deprecated_aliaswarning.#libresolution regression passed.sv@0.15.4: build and 5 Vitest tests passed.svelte-checkstill reports existing Kit 2 hook-type incompatibilities; this is documented as evidence, not full Kit 2 certification.bun run graphify:updatecompleted.Closes #584