Repository navigation
fix(dashboard): clarify dialog trigger affordances - #596
Merged
Merged
Conversation
Contributor
Author
|
Review completed — no merge blockers. Reviewed head
MERGE DECISION: READY TO MERGE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First dashboard-family change from the Skeleton/Tailwind audit in #594. Adds Tailwind
cursor-pointerto enabled Skeleton dialog triggers in the admin layout and users modal; the Skeleton trigger components and their behavior remain unchanged. The audit issue remains open for the other component families.Validation
bun run build:all— passed.bun run lint— passed.bun run typecheck— passed.bun run test— 1,183 passed; two unrelated tests timed out under the full-suite run (structural-duplicationand npm tarball metadata).bash scripts/test-scaffold.sh dashboard— build/design-system checks passed, but scaffold Vitest failed because the configured test database contains pre-existing rows and is not isolated.