Skip to content

fix(dashboard): clarify dialog trigger affordances - #596

Merged
LudoLoops merged 1 commit into
mainfrom
594-skeleton-v5-component-audit
Oct 12, 2026
Merged

LudoLoops merged 1 commit into
mainfrom
594-skeleton-v5-component-audit

Conversation

@LudoLoops

Copy link
Copy Markdown
Contributor

Summary

First dashboard-family change from the Skeleton/Tailwind audit in #594. Adds Tailwind cursor-pointer to enabled Skeleton dialog triggers in the admin layout and users modal; the Skeleton trigger components and their behavior remain unchanged. The audit issue remains open for the other component families.

Validation

  • bun run build:all — passed.
  • bun run lint — passed.
  • bun run typecheck — passed.
  • Targeted trigger/admin tests — passed.
  • bun run test — 1,183 passed; two unrelated tests timed out under the full-suite run (structural-duplication and npm tarball metadata).
  • bash scripts/test-scaffold.sh dashboard — build/design-system checks passed, but scaffold Vitest failed because the configured test database contains pre-existing rows and is not isolated.

Copy link
Copy Markdown
Contributor Author

Review completed — no merge blockers.

Reviewed head 6905d1c172aa2758e4ede0e52792b1e56ef6a685 against main as the dashboard-dialog-trigger tranche of issue #594.

  • The changes are limited to adding Tailwind cursor-pointer to seven existing Skeleton Dialog.Trigger/Dialog.CloseTrigger instances in AdminLayout.svelte and the admin users page. Skeleton v5's btn/btn-icon utilities do not provide a default pointer cursor. No trigger implementation, click handler, modal state, disabled contract, focus class, markup hierarchy, or form action is changed. No custom CSS or duplicate component abstraction is introduced.
  • The dashboard file mirror in the generated packages/svforge/src/templates.ts matches the two source files. The new static-source regression test checks the affected trigger classes, and the patch Changeset and Graphify outputs are included.
  • GitHub Actions CI refactor(compat): remove SvelteKit 3 deprecated $lib alias from generated projects #584 completed successfully on this exact head. Its required quality job passed lint, typecheck, OSV and Better Auth audits, generated-manifest freshness, build-all, and the full Run tests step. The two reported local root-suite timeouts did not reproduce in CI. The main-smoke job is correctly skipped on PRs under the repository workflow.
  • The reported local Dashboard scaffold Vitest failure occurred with a pre-populated test database. scripts/test-scaffold.sh uses the shared default sf_dashboard_test database unless TEST_DATABASE_URL is supplied; it does not guarantee a fresh database for each local run. Because this PR changes only static trigger cursor classes and the generated Dashboard build/design-system checks passed, the database-state failure does not establish a regression introduced by this PR. Follow-up: rerun the Dashboard scaffold with a clean, isolated test database and address fixture isolation separately if the failure persists.
  • No unresolved review threads. GitHub reports the PR clean and mergeable. Issue refactor(ui): audit all scaffolded components for a minimal Skeleton v5-first baseline #594 must remain open for the remaining component families.

MERGE DECISION: READY TO MERGE.

@LudoLoops
LudoLoops merged commit d9d2e71 into main Oct 12, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant