Skip to content

Replace fkirc/skip-duplicate-actions with dorny/paths-filter - #6186

Merged
rtibbles merged 1 commit into
learningequality:unstablefrom
rtibblesbot:issue-6185-39fc0e
Sep 26, 2026
Merged

rtibbles merged 1 commit into
learningequality:unstablefrom
rtibblesbot:issue-6185-39fc0e

Conversation

@rtibblesbot

@rtibblesbot rtibblesbot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Swap every fkirc/skip-duplicate-actions path gate for dorny/paths-filter with the same patterns; v* tag pushes still build both container images.
  • No ruleset change needed.

References

Reviewer guidance

  • actions: read is dropped; only fkirc needed it.
  • Pushes to hotfixes/master now diff against their merge-base with unstable, so gated jobs run more often there.

AI usage

Claude Code mapped the fkirc path lists to paths-filter and gathered the fork run evidence. Verified with actionlint, a filter-vs-old-list comparison script, a picomatch check, and fork CI runs.

🤖 Generated with Claude Code

Deviations from the issue spec

Criterion Why not
Every path list keeps its current patterns pre-commit.yml ignores **/*.po/**/*.json, not **.po/**.json: picomatch applies !**.po at the repo root only, so the literal pattern would lint PRs touching only nested .po/.json files. Matched files are unchanged.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?
  • Ran pre-flight CI checks (lint, format, tests) and verified all pass
  • Rebased onto the target branch and resolved any conflicts
  • Reorganized commit history into clean, logical commits
  • Audited the diff to ensure only issue-relevant files are changed
  • Built PR body from the repository's PR template with evidence blocks
@rtibblesbot

🟡 Waiting for feedback

Last updated: 2026-09-25 09:20 UTC

- One detect job in containerbuild.yml with postgres/nginx filters; tag pushes run both builds.
- pre-commit.yml maps paths_ignore to negated `**/*` patterns with `every`.
- Drop `actions: read`, which only fkirc needed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@rtibbles
rtibbles marked this pull request as ready for review September 25, 2026 17:16
@rtibbles
rtibbles requested review from a team and marcellamaki September 25, 2026 17:16
@rtibbles rtibbles self-assigned this Sep 25, 2026
@rtibbles
rtibbles merged commit b12c328 into learningequality:unstable Sep 26, 2026
237 checks passed
@rtibblesbot
rtibblesbot deleted the issue-6185-39fc0e branch September 26, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace fkirc/skip-duplicate-actions in CI workflows

2 participants