Use Django's built-in password reset confirm flow - #6175
Merged
Merged
Conversation
rtibbles
marked this pull request as ready for review
September 24, 2026 22:17
Let PasswordResetConfirmView.dispatch gate the form so the token is validated from the session, and post the new password to the set-password URL instead of the emailed token. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EZoTHtTrhSDCJsx4PA2AXu
rtibbles
force-pushed
the
reset_confirm_fix
branch
from
September 24, 2026 23:04
9809d05 to
d21ad67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Reviewer guidance
pnpm devserver, then request a reset foruser@a.comat/accounts/#/forgot-password— the reset link prints in the server log.http://localhost:8080— it lands on/accounts/#/reset-password?uidb64=…with no token in the URL.password-reset-flow.webm
Server log for the recorded flow (steps 2, 3 and 5):
Server log for POSTs without a valid reset session:
AI usage
Used Claude Code to rework the reset confirm view onto Django's built-in flow and write the tests. Verified with the Django and Jest test suites, the pre-commit linters, and manual QA in a browser against a local devserver.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EZoTHtTrhSDCJsx4PA2AXu