fix: serve the requested schema version's columns from importmetadata - #6174
Open
rtibblesbot wants to merge 1 commit into
Open
rtibblesbot wants to merge 1 commit into
rtibblesbot wants to merge 1 commit into
Conversation
rtibblesbot
marked this pull request as ready for review
September 24, 2026 22:19
- Vendor Kolibri's frozen v5/v6 column maps; `schema_version` selects one - No `schema_version` keeps today's v5 ∪ v6 columns - Bad `schema_version` returns Kolibri's JSON 400 bodies Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6172-298b5a
branch
from
September 24, 2026 22:24
b054a18 to
5c81e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2/importmetadataserves Kolibri's frozen column map for the requestedschema_version; previously a v5 request got v6 columns.schema_version: response unchanged.References
Fixes #6172. Client side: learningequality/kolibri#15358.
Reviewer guidance
schema_version, the response has the v5 ∪ v6 columns, so it has bothfile_sizeandfile_size_bigint. Should the default be v6 alone?05and+6are normalised to5/6and served, not rejected.AI usage
Used Claude Code to port Kolibri's per-version column maps and validation, and to write the tests. Verified with the
kolibri_publictest suite and flake8.🤖 Generated with Claude Code
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-09-24 22:24 UTC