Paginate importmetadata on max_results and include descendants - #6173
Open
rtibblesbot wants to merge 1 commit into
Open
rtibblesbot wants to merge 1 commit into
rtibblesbot wants to merge 1 commit into
Conversation
rtibblesbot
marked this pull request as ready for review
September 24, 2026 20:26
Matches Kolibri's endpoint so course imports can fetch metadata from Studio. Closes learningequality#6170 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6170-5557d0
branch
from
September 24, 2026 20:30
e16dcdd to
7f92a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2/importmetadatapages onmax_resultsand includes descendants ondescendants, matching Kolibri's endpoint.References
Closes #6170. Kolibri client: learningequality/kolibri#15352.
Reviewer guidance
_get_import_metadata(NetworkClient(<studio>), SimpleNamespace(contentnode_id=<topic id>, metadata={"import_descendants": True}))—content_contentnodeholds the topic, its ancestors and every descendant, once each.descendants=falseenables descendants, as in Kolibri — compare to"true"instead?AI usage
Claude Code implemented this test-first from Kolibri's endpoint. Verified with the importmetadata tests and Kolibri's
_get_import_metadataagainst a local Studio (2 → 14 nodes imported for a course topic).🤖 Generated with Claude Code
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-09-24 20:31 UTC