Skip to content

Refresh automation.yml from the shared template - #6156

Merged
rtibbles merged 1 commit into
unstablefrom
refresh-automation-template
Sep 21, 2026
Merged

rtibbles merged 1 commit into
unstablefrom
refresh-automation-template

Conversation

@akolson

@akolson akolson commented Sep 21, 2026

Copy link
Copy Markdown
Member

The copy of automation.yml in this repo predates three fixes in learningequality/.github. This replaces it with the current automation-template.yml from main.

  • The blank line above name: is removed. yamlfmt v0.16.0 and later strip it, so a repo on a newer pin rewrites the file on its next pre-commit run.
  • on: carries # zizmor: ignore[dangerous-triggers]. zizmor reports pull_request_target as a dangerous trigger, and the callers this template replaced each carried the same inline ignore.
  • Event keys and type lists are sorted. Sorting keeps this file stable when an automation is toggled in the registry, so a seasonal change no longer reshuffles it.

No trigger changes. The event and activity type sets are identical, so every automation fires exactly as it does today.

@akolson
akolson requested review from a team and rtibblesbot September 21, 2026 15:50
@rtibblesbot

rtibblesbot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Waiting for changes

Last updated: 2026-09-21 15:58 UTC

@rtibblesbot rtibblesbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #6156 checks out: the refreshed workflow is a verbatim copy of the shared template, and no trigger changed.

diff against learningequality/.github@main:automation-template.yml is empty. Set-comparing the on: keys across both revisions leaves all six triggers matching.

CI passing. No UI files, so no visual verification.

  • nitpick: two PR-body rationales describe the template's home repo, not Studio (inline).

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Ran a phased review pipeline over the pull request diff:

  • Classified the diff to select review passes (core, frontend, backend) and whether manual QA was required
  • Core review pass checked correctness, design, architecture, testing, completeness, and DRY/SRP/Rule-of-Three principles
  • Specialized frontend/backend review passes applied framework-specific lenses where those files changed
  • For UI changes: manual QA and an accessibility audit against a live dev server, when available
  • Checked CI status and linked issue acceptance criteria
  • Synthesized one review from those passes and chose the verdict from the findings, CI status, and QA evidence

- reopened
- edited
- review_request_removed
on: # zizmor: ignore[dangerous-triggers]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Both PR-body rationales for this ignore line are false in Studio.

  • "the callers this template replaced each carried the same inline ignore" — none of the seven callers deleted in Replace the seven automation callers with the central entry point #6137 contain a zizmor comment. git log --all -S zizmor -- .github/ returns only this commit, so zizmor runs nowhere here and the ignore is inert.
  • "a repo on a newer pin rewrites the file on its next pre-commit run" — .pre-commit-config.yaml has no yamlfmt hook.

Keep the line for template parity. Drop both rationales from the PR body.

@rtibbles
rtibbles merged commit c3fba48 into unstable Sep 21, 2026
72 checks passed
@rtibbles
rtibbles deleted the refresh-automation-template branch September 21, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants