Refresh automation.yml from the shared template - #6156
Merged
Merged
Conversation
Contributor
🟡 Waiting for changesLast updated: 2026-09-21 15:58 UTC |
rtibblesbot
approved these changes
Sep 21, 2026
rtibblesbot
left a comment
Contributor
There was a problem hiding this comment.
PR #6156 checks out: the refreshed workflow is a verbatim copy of the shared template, and no trigger changed.
diff against learningequality/.github@main:automation-template.yml is empty. Set-comparing the on: keys across both revisions leaves all six triggers matching.
CI passing. No UI files, so no visual verification.
- nitpick: two PR-body rationales describe the template's home repo, not Studio (inline).
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Ran a phased review pipeline over the pull request diff:
- Classified the diff to select review passes (core, frontend, backend) and whether manual QA was required
- Core review pass checked correctness, design, architecture, testing, completeness, and DRY/SRP/Rule-of-Three principles
- Specialized frontend/backend review passes applied framework-specific lenses where those files changed
- For UI changes: manual QA and an accessibility audit against a live dev server, when available
- Checked CI status and linked issue acceptance criteria
- Synthesized one review from those passes and chose the verdict from the findings, CI status, and QA evidence
| - reopened | ||
| - edited | ||
| - review_request_removed | ||
| on: # zizmor: ignore[dangerous-triggers] |
Contributor
There was a problem hiding this comment.
nitpick: Both PR-body rationales for this ignore line are false in Studio.
- "the callers this template replaced each carried the same inline ignore" — none of the seven callers deleted in Replace the seven automation callers with the central entry point #6137 contain a
zizmorcomment.git log --all -S zizmor -- .github/returns only this commit, so zizmor runs nowhere here and the ignore is inert. - "a repo on a newer pin rewrites the file on its next pre-commit run" —
.pre-commit-config.yamlhas no yamlfmt hook.
Keep the line for template parity. Drop both rationales from the PR body.
rtibbles
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy of
automation.ymlin this repo predates three fixes inlearningequality/.github. This replaces it with the currentautomation-template.ymlfrommain.name:is removed. yamlfmt v0.16.0 and later strip it, so a repo on a newer pin rewrites the file on its next pre-commit run.on:carries# zizmor: ignore[dangerous-triggers]. zizmor reportspull_request_targetas a dangerous trigger, and the callers this template replaced each carried the same inline ignore.No trigger changes. The event and activity type sets are identical, so every automation fires exactly as it does today.