Skip to content

Replace fkirc/skip-duplicate-actions with paths-filter - #360

Merged
rtibbles merged 1 commit into
learningequality:release-v0.9.xfrom
rtibblesbot:issue-359-ed2947
Sep 26, 2026
Merged

rtibbles merged 1 commit into
learningequality:release-v0.9.xfrom
rtibblesbot:issue-359-ed2947

Conversation

@rtibblesbot

@rtibblesbot rtibblesbot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Four workflows gate jobs on fkirc/skip-duplicate-actions, which is being phased out org-wide. Docs now uses native paths:; the other three use dorny/paths-filter with the same path lists and job gates.

TODO

  • Have tests been written for the new code?
  • Has documentation been written/updated?
  • New dependencies (if any) added to requirements file

Reviewer guidance

No ruleset change needed; job names still match the ruleset's required checks.

Fork runs:

Open risks:

  • Pushes to non-default branches diff against their merge-base with the default branch, so gated jobs run on more pushes than under fkirc.
  • Native paths: inspects only the first 300 changed files; larger PRs may skip Docs.

Issues addressed

Closes #359. Strategy: learningequality/.github#83.

Documentation

🤖 Generated with Claude Code

Deviations from the issue spec

Criterion Why not
Every path list keeps its current patterns pre-commit.yml uses !**/*.po / !**/*.json instead of **.po / **.json: under paths-filter's picomatch, !**.po only excludes root-level files. Match set is unchanged.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?
  • Ran pre-flight CI checks (lint, format, tests) and verified all pass
  • Rebased onto the target branch and resolved any conflicts
  • Reorganized commit history into clean, logical commits
  • Audited the diff to ensure only issue-relevant files are changed
  • Built PR body from the repository's PR template with evidence blocks
@rtibblesbot

🟡 Waiting for feedback

Last updated: 2026-09-25 08:33 UTC

- check-docs.yml: native `paths:`; drop pre_job
- check_migrations_sqlite.yml, tox.yml, pre-commit.yml: dorny/paths-filter detect job
- pre-commit.yml: `every` + '!**/*.po', '!**/*.json' to keep nested-file ignores

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@rtibbles
rtibbles marked this pull request as ready for review September 25, 2026 17:16
@rtibbles
rtibbles merged commit d248059 into learningequality:release-v0.9.x Sep 26, 2026
186 checks passed
@rtibblesbot
rtibblesbot deleted the issue-359-ed2947 branch September 26, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace fkirc/skip-duplicate-actions in CI workflows

2 participants