Add archive contents_sha256 and ARCHIVE_FORMATS - #242
Merged
Merged
Conversation
rtibblesbot
marked this pull request as ready for review
September 23, 2026 06:30
rtibbles
requested changes
Sep 25, 2026
| BLOOMPUB_MIMETYPE = "application/bloompub+zip" | ||
|
|
||
| # Zip-based formats identified by le_utils.archive.contents_sha256. | ||
| # FROZEN: ricecooker and Studio's upload Cloud Function pin this; any change breaks their index lookups. |
Member
There was a problem hiding this comment.
blocking: "Any change breaks their index lookups" overstates it: adding a format breaks no existing lookup; removing one orphans its index entries.
Suggested change
| # FROZEN: ricecooker and Studio's upload Cloud Function pin this; any change breaks their index lookups. | |
| # FROZEN: ricecooker and Studio's upload Cloud Function pin this; removing a format orphans its index entries. |
Contributor
Author
There was a problem hiding this comment.
Applied in 00e9343. Searched the diff (README, archive.py docstring, tests) for other breakage claims about the frozen definition: 0 more; they say only "frozen"/"index by".
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Compression- and metadata-independent identity hash for zip archives. Fixes learningequality#241 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-241-85627b
branch
from
September 25, 2026 03:21
0a06e8f to
28c428b
Compare
rtibbles
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archive.contents_sha256: zip identity hash independent of compression and metadata.file_formats.ARCHIVE_FORMATS.References
Fixes #241. Parent: learningequality/ricecooker#722.
Reviewer guidance
ZipInfo.orig_filename, not.filename; is that the frozen choice consumers expect?AI usage
Used Claude Code to implement the hash, constant and tests from the issue's definition. Verified with the full test suite, an independent recomputation of the pinned digest, and prek hooks.
🤖 Generated with Claude Code
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-09-25 03:23 UTC