Repository navigation
Conversation
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declares
diagnostic-eventsin the server-node, node-client, react and vue contract test services so the new sdk-test-harness testevents/diagnostic eventsruns. The test was added in v3.2.0-alpha.20 and checks thatdiagnostic-initreaches the diagnostic route and that no diagnostic payload reaches the analytics route.enableDiagnosticstodiagnosticOptOut, so the entities need no other change.Testing
I ran the v3.2.0-alpha.20 harness locally with
-run diagnosticagainst:USE_MOBILE_KEY=false.All 3 diagnostic tests passed in each run.
I did not run react or vue locally. They use the same shared
sdk-clientevent code as node-client with the JS key.Link to Devin session: https://app.devin.ai/sessions/56b8ade9602745fbba00e59a531bbefa
Open in Devin Desktop: https://app.devin.ai/desktop/session/56b8ade9602745fbba00e59a531bbefa?variant=devin
Requested by: @joker23