Skip to content

chore: Declare the diagnostic-events capability in the server-node, node-client, react and vue contract tests - #2232

Draft
joker23 wants to merge 1 commit into
mainfrom
devin/1795208960-diagnostic-events-capability
Draft

joker23 wants to merge 1 commit into
mainfrom
devin/1795208960-diagnostic-events-capability

Conversation

@joker23

@joker23 joker23 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Declares diagnostic-events in the server-node, node-client, react and vue contract test services so the new sdk-test-harness test events/diagnostic events runs. The test was added in v3.2.0-alpha.20 and checks that diagnostic-init reaches the diagnostic route and that no diagnostic payload reaches the analytics route.

Testing

I ran the v3.2.0-alpha.20 harness locally with -run diagnostic against:

  • server-node,
  • node-client with the mobile key,
  • node-client with USE_MOBILE_KEY=false.

All 3 diagnostic tests passed in each run.

I did not run react or vue locally. They use the same shared sdk-client event code as node-client with the JS key.

Link to Devin session: https://app.devin.ai/sessions/56b8ade9602745fbba00e59a531bbefa
Open in Devin Desktop: https://app.devin.ai/desktop/session/56b8ade9602745fbba00e59a531bbefa?variant=devin
Requested by: @joker23

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot added the devin-pr PRs created by Devin AI label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 19243 bytes
Compressed size limit: 33000
Uncompressed size: 106351 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 34655 bytes
Compressed size limit: 35500
Uncompressed size: 123734 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26493 bytes
Compressed size limit: 44000
Uncompressed size: 172261 bytes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PRs created by Devin AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant