Repository navigation
Conversation
joker23
force-pushed
the
skz/electron-sdk-next-storage
branch
from
November 20, 2026 17:49
7860ebd to
cfcda97
Compare
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
commented
Nov 20, 2026
| * | ||
| * This option has no effect when {@link ElectronOptions.storage} is set. | ||
| * | ||
| * Defaults to `false`. |
Contributor
Author
There was a problem hiding this comment.
open to discussion on whether or not we want to make this default to true ... false is chosen to be closer to previous version of the SDK
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the Electron flag cache and adds two options:
storagereplaces the built-in file cache with an app-suppliedLDElectronStorage(get,set,clear). The SDK catches and logs its errors.encryptStorageencrypts the built-in cache with Electron'ssafeStorageand writes it to its ownldcache.encfile. A plain-text cache from an earlier run is deleted. When encryption is not available, including Linux with thebasic_textbackend, flags stay in memory only and the SDK logs a warning.The built-in cache moves into an SDK-owned
ldclient-user-cachedirectory underuserData, created with mode0o700, and the symlink check now guards that directory.ElectronPlatformtakes the validated options object, which also carrieswrapperNameandwrapperVersioninto the SDK info.Additional context
resetElectronStorageis@internalagain. The contract-test entity still imports it at runtime.Related tickets
sdk-2172