Repository navigation
feat: [SDK-3679] Add rust-eol-versions action and sdk-rust-versions workflow - #131
Merged
Merged
Conversation
Generated-by: termag
keelerm84
marked this pull request as ready for review
November 18, 2026 14:28
joker23
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rust repositories each carry a
check-rust-versions.ymlthat pastesfromJSON(env.fetchApiData)[2].cyclefrom endoflife.date into arun:script with${{ }}. The result then goes intosedin a job withcontents: writeandpull-requests: write. A change to the endoflife.date feed could run commands with that token. Cursor's security review flagged the copy in hello-rust#32. rust-server-sdk, rust-sdk-transport and rust-eventsource-client have the same code.This adds the Rust equivalent of
go-eol-versionsandsdk-go-versions.yml:actions/rust-eol-versionsreads the feed withjq, takes the cycle atoffsetreleases back from the newest (default 2, the third newest, which is the current policy), and fails unless it matches^[0-9]+\.[0-9]+$.offsetmust be a non-negative integer..github/workflows/sdk-rust-versions.ymlreadstarget=from.github/variables/rust-versions.env. When the target changes, it rewrites that line andrust-versionin eachcargo_tomlsfile, then opens a<pr_title_prefix>: Bump MSRV from <old> to <new>PR. Values reach the shell only through environment variables. The update step checks the version format again before it runssed. The checkout does not persist credentials..github/workflows/test-rust-eol-versions.ymlruns the action against the live feed, and against local payloads with command substitution, a closing quote, a missing entry, or a bad offset. Each of those must fail with no output.release-please tracks the action from 0.1.0. After this merges, I'll switch the three Rust SDK repos and hello-rust to the shared workflow.
Opened from termag
Note
Overview
Introduces
rust-eol-versions, a composite action that picks a Rust release from endoflife.date (default: third newest) and only exposes atargetcycle string afteroffsetand version regex validation, so downstream shell steps are not driven by raw third-party JSON.Adds the reusable
sdk-rust-versionsworkflow to compare that target withtarget=in a versions env file, update listedCargo.tomlrust-versionfields when needed, and open MSRV bump PRs with credential persistence disabled and a second format check beforesed.Adds
test-rust-eol-versionsCI (live feed plus malicious/malformed payload matrix) and wires release-please / README docs for the new action and workflow.Reviewed by Cursor Bugbot for commit f4a14c2. Bugbot is set up for automated code reviews on this repo. Configure here.
Related Jira issue: SDK-3679: Share and harden the Rust MSRV check workflow in gh-actions