Repository navigation
fix: [SDK-3651] Run the shared actions on Node.js 24 - #128
Merged
Merged
Conversation
Generated-by: termag
Generated-by: termag
kinyoklion
approved these changes
Nov 17, 2026
kinyoklion
self-requested a review
November 17, 2026 19:21
kinyoklion
requested changes
Nov 17, 2026
kinyoklion
left a comment
Member
There was a problem hiding this comment.
I am not sure about this one.
Generated-by: termag
kinyoklion
approved these changes
Nov 17, 2026
Generated-by: termag
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a27f21b. Configure here.
Generated-by: termag
kinyoklion
approved these changes
Nov 17, 2026
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
GitHub has deprecated the Node.js 20 runtime for JavaScript actions, and workflows in this repository print a deprecation warning on every run. This PR bumps each action that runs on Node.js 20 or older to its latest major release, which runs on Node.js 24. Tag pins stay tag pins. SHA pins move to the SHA of the new release, with a version comment.
actions/cache1bd1e32 (v4.2.0)55cc834 (v6.1.0)actions/checkoutv3,v4v7actions/download-artifact65a9edc (v4.1.7)9000827 (v8.0.2)actions/setup-node60edb5d (v4.0.2)949feb2 (v7.1.0)actions/stalev7v11actions/upload-artifact0b2256b (v4.3.4),6546280 (v4.3.3)cf430e0 (v7.0.2)amannn/action-semantic-pull-requeste32d7e6 (v5)2252a14 (v6.1.2)googleapis/release-please-actionc2a5a2b (v4.3.0)45996ed (v5.0.0)launchdarkly/gh-actions/actions/release-secretsrelease-secrets-v1.2.0release-secrets-v1.2.1None of the bumps change the inputs this repository passes.
Behavior changes to know about:
actions/checkoutv6 and later store the persisted credentials in a separate file under$RUNNER_TEMP, not in.git/config.actions/setup-nodev5 and later turn on dependency caching whenpackage.jsonhas apackageManagerfield. v6 and later do this only for npm.actions/download-artifactv8 fails the step on a digest mismatch. Earlier versions only logged a warning.release-secrets-v1.2.1reads SSM parameters with a bundled script in place ofdkershner6/aws-ssm-getparameters-action. Its inputs are the same.Several of these files are shared by the SDK repositories, so this PR also removes Node.js 20 warnings there:
lint-pr-title.ymland thedependency-scanactions: repositories that use@mainpick up the fix as soon as this PR merges.verify-hello-appnow usesrelease-secrets-v1.2.1. The hello repositories pick this up after the nextverify-hello-apprelease, when they bump to the new tag.generate-sbomnow setspackage-manager-cache: falseonsetup-node. That step only installscdxgenglobally. Without this,setup-nodev5 and later would try to cache the calling repository's npm dependencies, and fail if that repository has no lockfile.evaluate-policynow downloads the BOM artifacts into$RUNNER_TEMP/bomswithmerge-multiple: true. From v5 on,download-artifactputs a single matched artifact directly inpathand drops the<artifact-name>/subdirectory, so the oldbom-*/*.jsonmerge input matched nothing. Every caller runs onegenerate-sbomjob, so without this change the Evaluate Policy job would fail in every repository that calls it.The new
test-dependency-scan.ymlworkflow runs both dependency-scan actions from the branch under test. The shared workflow calls them at@main, so before this a change reached every caller untested. On this PR the workflow failed in Merge BOMs before the fix and passes after it.Opened from termag
Note
Overview
Upgrades shared workflows and composite actions from deprecated Node.js 20–based GitHub Action majors to current releases (checkout, cache, setup-node, upload/download-artifact, stale, release-please, semantic PR title, and
release-secrets-v1.2.1), keeping existing inputs and SHA/tag pin style.Dependency-scan adjusts for newer artifact/download behavior:
evaluate-policydownloads BOMs into$RUNNER_TEMP/bomswithmerge-multiple, merges from that path, and bumps cache/upload/download pins;generate-sbomsetspackage-manager-cache: falseonsetup-nodeso globalcdxgeninstall does not cache the caller’s npm deps. A newtest-dependency-scanworkflow exercisesgenerate-sbomandevaluate-policyon PR/push toactions/dependency-scan/**before consumers on@mainpick up changes.Reviewed by Cursor Bugbot for commit 3b80d87. Bugbot is set up for automated code reviews on this repo. Configure here.
Related Jira issue: SDK-3651: Wave 1: Bump GitHub Actions to their Node.js 24 majors in SDK repositories