Skip to content

fix: [SDK-3651] Run the shared actions on Node.js 24 - #128

Merged
keelerm84 merged 5 commits into
mainfrom
mk/SDK-3651/node24-actions
Nov 17, 2026
Merged

keelerm84 merged 5 commits into
mainfrom
mk/SDK-3651/node24-actions

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

GitHub has deprecated the Node.js 20 runtime for JavaScript actions, and workflows in this repository print a deprecation warning on every run. This PR bumps each action that runs on Node.js 20 or older to its latest major release, which runs on Node.js 24. Tag pins stay tag pins. SHA pins move to the SHA of the new release, with a version comment.

Action From To
actions/cache 1bd1e32 (v4.2.0) 55cc834 (v6.1.0)
actions/checkout v3, v4 v7
actions/download-artifact 65a9edc (v4.1.7) 9000827 (v8.0.2)
actions/setup-node 60edb5d (v4.0.2) 949feb2 (v7.1.0)
actions/stale v7 v11
actions/upload-artifact 0b2256b (v4.3.4), 6546280 (v4.3.3) cf430e0 (v7.0.2)
amannn/action-semantic-pull-request e32d7e6 (v5) 2252a14 (v6.1.2)
googleapis/release-please-action c2a5a2b (v4.3.0) 45996ed (v5.0.0)
launchdarkly/gh-actions/actions/release-secrets release-secrets-v1.2.0 release-secrets-v1.2.1

None of the bumps change the inputs this repository passes.

Behavior changes to know about:

  • actions/checkout v6 and later store the persisted credentials in a separate file under $RUNNER_TEMP, not in .git/config.
  • actions/setup-node v5 and later turn on dependency caching when package.json has a packageManager field. v6 and later do this only for npm.
  • actions/download-artifact v8 fails the step on a digest mismatch. Earlier versions only logged a warning.
  • release-secrets-v1.2.1 reads SSM parameters with a bundled script in place of dkershner6/aws-ssm-getparameters-action. Its inputs are the same.

Several of these files are shared by the SDK repositories, so this PR also removes Node.js 20 warnings there:

  • lint-pr-title.yml and the dependency-scan actions: repositories that use @main pick up the fix as soon as this PR merges.
  • verify-hello-app now uses release-secrets-v1.2.1. The hello repositories pick this up after the next verify-hello-app release, when they bump to the new tag.

generate-sbom now sets package-manager-cache: false on setup-node. That step only installs cdxgen globally. Without this, setup-node v5 and later would try to cache the calling repository's npm dependencies, and fail if that repository has no lockfile.

evaluate-policy now downloads the BOM artifacts into $RUNNER_TEMP/boms with merge-multiple: true. From v5 on, download-artifact puts a single matched artifact directly in path and drops the <artifact-name>/ subdirectory, so the old bom-*/*.json merge input matched nothing. Every caller runs one generate-sbom job, so without this change the Evaluate Policy job would fail in every repository that calls it.

The new test-dependency-scan.yml workflow runs both dependency-scan actions from the branch under test. The shared workflow calls them at @main, so before this a change reached every caller untested. On this PR the workflow failed in Merge BOMs before the fix and passes after it.

Opened from termag


Note

Overview
Upgrades shared workflows and composite actions from deprecated Node.js 20–based GitHub Action majors to current releases (checkout, cache, setup-node, upload/download-artifact, stale, release-please, semantic PR title, and release-secrets-v1.2.1), keeping existing inputs and SHA/tag pin style.

Dependency-scan adjusts for newer artifact/download behavior: evaluate-policy downloads BOMs into $RUNNER_TEMP/boms with merge-multiple, merges from that path, and bumps cache/upload/download pins; generate-sbom sets package-manager-cache: false on setup-node so global cdxgen install does not cache the caller’s npm deps. A new test-dependency-scan workflow exercises generate-sbom and evaluate-policy on PR/push to actions/dependency-scan/** before consumers on @main pick up changes.

Reviewed by Cursor Bugbot for commit 3b80d87. Bugbot is set up for automated code reviews on this repo. Configure here.


Related Jira issue: SDK-3651: Wave 1: Bump GitHub Actions to their Node.js 24 majors in SDK repositories

@keelerm84
keelerm84 requested a review from a team as a code owner November 17, 2026 19:04
@launchdarkly-upra launchdarkly-upra Bot changed the title chore: Bump GitHub Actions to their Node.js 24 versions chore: [SDK-3651] Bump GitHub Actions to their Node.js 24 versions Nov 17, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@kinyoklion
kinyoklion self-requested a review November 17, 2026 19:21

@kinyoklion kinyoklion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this one.

@keelerm84 keelerm84 changed the title chore: [SDK-3651] Bump GitHub Actions to their Node.js 24 versions fix: [SDK-3651] Run the shared actions on Node.js 24 Nov 17, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a27f21b. Configure here.

@keelerm84
keelerm84 merged commit af08d2a into main Nov 17, 2026
5 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-3651/node24-actions branch November 17, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants