Repository navigation
chore(deps): update launchdarkly/gh-actions requirement to release-secrets-v1.2.2 - #29
dependabot[bot] wants to merge 1 commit into
Conversation
…crets-v1.2.2 Updates the requirements on [launchdarkly/gh-actions](https://github.com/launchdarkly/gh-actions) to permit the latest version. - [Release notes](https://github.com/launchdarkly/gh-actions/releases) - [Commits](https://github.com/launchdarkly/gh-actions/commits/release-secrets-v1.2.2) --- updated-dependencies: - dependency-name: launchdarkly/gh-actions dependency-version: 1.2.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1a9d8fd. Configure here.
|
|
||
| - name: Sign DLLs | ||
| uses: launchdarkly/gh-actions/actions/sign-dlls@sign-dlls-v1.0.2 | ||
| uses: launchdarkly/gh-actions/actions/sign-dlls@release-secrets-v1.2.2 |
There was a problem hiding this comment.
Wrong tag pin for sign-dlls
High Severity
The sign-dlls action was retagged from sign-dlls-v1.0.2 to release-secrets-v1.2.2. That ref belongs to a different action in the same monorepo, so the publish job now pins DLL signing to an unrelated release-secrets release instead of a sign-dlls version. Releases can sign with the wrong action revision or fail the signing step entirely.
Reviewed by Cursor Bugbot for commit 1a9d8fd. Configure here.
There was a problem hiding this comment.
Risk: high.
Automated risk review (dry run): High
This PR would not be automatically approved. Human approval required.
Why: It changes .github/workflows/publish.yml, a CI/publish workflow that fetches release secrets and signs DLLs, which cannot be Low. Cursor Bugbot also reported an unresolved high-severity finding that sign-dlls was pinned to the unrelated release-secrets-v1.2.2 tag. Human review is needed and no reviewers were assigned.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
|
Closing this PR. It sets an invalid ref for
Dependabot treats all actions in |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
jsonbailey
left a comment
There was a problem hiding this comment.
Do not merge. This PR sets an invalid ref for launchdarkly/gh-actions:
sign-dlls@release-secrets-v1.2.2: the tag is for a different action
Dependabot treats all actions in launchdarkly/gh-actions as one dependency, because the tags use a dash between the action name and the version. It then moves every ref to the newest tag in the repo, even when that tag belongs to another action. The fix is in launchdarkly/gh-actions#137.




Updates the requirements on launchdarkly/gh-actions to permit the latest version.
Release notes
Sourced from launchdarkly/gh-actions's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Overview
Bumps the Get secrets step in
publish.ymlfromrelease-secrets-v1.2.1torelease-secrets-v1.2.2(dependency fixes in the release-secrets action, per upstream release notes).The Sign DLLs step’s action ref also changes from
sign-dlls-v1.0.2torelease-secrets-v1.2.2while still callingactions/sign-dlls—worth confirming that tag is valid for the sign-dlls action and not an accidental Dependabot pin.Reviewed by Cursor Bugbot for commit 1a9d8fd. Bugbot is set up for automated code reviews on this repo. Configure here.