Skip to content

chore: Update sign-dlls to v1.0.2 for Node.js 24 - #27

Merged
keelerm84 merged 1 commit into
mainfrom
mk/SDK-3652/sign-dlls-v1.0.2
Nov 20, 2026
Merged

keelerm84 merged 1 commit into
mainfrom
mk/SDK-3652/sign-dlls-v1.0.2

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Updates launchdarkly/gh-actions/actions/sign-dlls from v1.0.0 to v1.0.2.

  • v1.0.2 replaces digicert/ssm-code-signing, which DigiCert archived and which runs on Node.js 16, with digicert/code-signing-software-trust-action, which runs on Node.js 24. This change was tested with a dry run of the dotnet-eventsource publish workflow, and the signed DLLs pass osslsigncode verify.
  • v1.0.1 makes the action fail when no DLL matches dll_name in build_configuration_path. Before, the signing step passed without signing anything.

Opened from termag


Note

Overview
The Publish Package workflow now pins launchdarkly/gh-actions/actions/sign-dlls at v1.0.2 instead of v1.0.0 for the release DLL signing step.

That upgrade moves signing onto DigiCert’s supported Software Trust action (Node.js 24) after the previous SSM action was archived, and picks up stricter behavior when no matching DLL is found under build_configuration_path.

Reviewed by Cursor Bugbot for commit b2d4ca0. Bugbot is set up for automated code reviews on this repo. Configure here.

@keelerm84
keelerm84 requested a review from a team as a code owner November 20, 2026 20:01

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: high.

Automated risk review (dry run): High

This PR would not be automatically approved. Human approval required.

Why: It changes .github/workflows/publish.yml to pin sign-dlls from v1.0.0 to v1.0.2, which is a CI/publish workflow and code-signing change. Human review is needed; no reviewers were assigned.

If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

@cursor cursor Bot added the risk:high label Nov 20, 2026
@keelerm84
keelerm84 merged commit 541e7f4 into main Nov 20, 2026
9 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-3652/sign-dlls-v1.0.2 branch November 20, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants