Repository navigation
chore: Update sign-dlls to v1.0.2 for Node.js 24 - #130
Merged
Merged
Conversation
Generated-by: termag
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: It changes .github/workflows/publish.yml (the Sign DLLs step pin from sign-dlls v1.0.0 to v1.0.2), which is a CI workflow and release-pipeline change and therefore cannot be Low. Human review is needed; no reviewers were assigned.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
tanderson-ld
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Updates
launchdarkly/gh-actions/actions/sign-dllsfrom v1.0.0 to v1.0.2.digicert/ssm-code-signing, which DigiCert archived and which runs on Node.js 16, withdigicert/code-signing-software-trust-action, which runs on Node.js 24. This change was tested with a dry run of the dotnet-eventsource publish workflow, and the signed DLLs passosslsigncode verify.dll_nameinbuild_configuration_path. Before, the signing step passed without signing anything.Opened from termag
Note
Overview
Bumps
launchdarkly/gh-actions/actions/sign-dllsfrom v1.0.0 to v1.0.2 in the publish workflow’s Sign DLLs step.That release moves DLL signing onto DigiCert’s
code-signing-software-trust-action(Node.js 24) instead of the archivedssm-code-signingaction, and v1.0.1 makes the step fail when no matching DLL is found underbuild_configuration_path(instead of succeeding without signing).Reviewed by Cursor Bugbot for commit 5e688a9. Bugbot is set up for automated code reviews on this repo. Configure here.