Skip to content

chore: Bump GitHub Actions to their Node.js 24 versions - #128

Merged
keelerm84 merged 2 commits into
mainfrom
mk/SDK-3651/node24-actions
Nov 18, 2026
Merged

keelerm84 merged 2 commits into
mainfrom
mk/SDK-3651/node24-actions

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

GitHub has deprecated the Node.js 20 runtime for JavaScript actions, and workflows in this repository print a deprecation warning on every run. This PR bumps each action that runs on Node.js 20 or older to its latest major release, which runs on Node.js 24. Tag pins stay tag pins. SHA pins move to the SHA of the new release, with a version comment.

Action From To
actions/checkout v4 v7
actions/setup-dotnet v4 v6
actions/upload-artifact v4 v7
launchdarkly/gh-actions/actions/release-secrets release-secrets-v1.2.0 release-secrets-v1.2.1
reactivecircus/android-emulator-runner 6b0df4b (2.30.1) a421e43 (v2.38.0)

None of the bumps change the inputs this repository passes.

Behavior changes to know about:

  • actions/checkout v6 and later store the persisted credentials in a separate file under $RUNNER_TEMP, not in .git/config.
  • release-secrets-v1.2.1 reads SSM parameters with a bundled script in place of dkershner6/aws-ssm-getparameters-action. Its inputs are the same.

The Android contract tests now build for net10.0-android, and their CI job sets up the .NET 10 SDK. ubuntu-latest now ships .NET SDK 11, which rejects the net9.0-android workload as out of support (NETSDK1202). That broke this job on main before this PR. scripts/start-android-test-service.sh and the Makefile comment follow the new target.

Opened from termag


Note

Overview
This PR upgrades GitHub Actions that run on deprecated Node.js 20 runtimes to current majors (checkout v7, setup-dotnet v6, upload-artifact v7). The same bumps land in composite actions (build-docs, publish, release-build) and in publish.yml (release-secrets v1.2.1). The Android contract-test job also moves android-emulator-runner to a newer SHA-pinned release (v2.38.0).

Android contract tests are retargeted from net9.0-android to net10.0-android, with CI installing the .NET 10 SDK instead of 9—so the job keeps working on runners where SDK 11 treats net9.0-android as out of support. Makefile comments and start-android-test-service.sh APK paths were updated to match the new output folder.

Reviewed by Cursor Bugbot for commit 1500a0b. Bugbot is set up for automated code reviews on this repo. Configure here.

@keelerm84
keelerm84 requested a review from a team as a code owner November 17, 2026 19:04
@cursor cursor Bot added the risk:medium label Nov 17, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium.

Automated risk review (dry run): Medium

This PR would not be automatically approved. Human approval required.

Why: It changes GitHub Actions workflow and composite-action pins in .github/workflows/ci.yml, .github/workflows/publish.yml, and related .github/actions/*/action.yml files, which are CI workflow definitions and cannot be classified as Low.

If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

@keelerm84
keelerm84 merged commit aec2cbd into main Nov 18, 2026
8 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-3651/node24-actions branch November 18, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants