Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/full-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ runs:
run_dynamodb: ${{ inputs.run_dynamodb }}
run_redis: ${{ inputs.run_redis }}

- uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.1
- uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.2
name: Get secrets
with:
aws_assume_role: ${{ inputs.aws_role }}
Expand All @@ -72,7 +72,7 @@ runs:
project_file: ${{ inputs.project_file }}

- name: Sign DLLs
uses: launchdarkly/gh-actions/actions/sign-dlls@sign-dlls-v1.0.0
uses: launchdarkly/gh-actions/actions/sign-dlls@release-secrets-v1.2.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong tag pins sign-dlls action

High Severity

The sign-dlls step is now pinned to release-secrets-v1.2.2 instead of a sign-dlls-* tag. That ref belongs to a different action in the same repo, so this step runs an unintended revision of sign-dlls and can break DLL signing on release.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit de673b9. Configure here.

with:
build_configuration_path: ${{ inputs.build_output_path }}
dll_name: ${{ inputs.dll_name }}
Expand Down
Loading