Repository navigation
chore(deps): update launchdarkly/gh-actions requirement to release-secrets-v1.2.2 - #423
Conversation
…crets-v1.2.2 Updates the requirements on [launchdarkly/gh-actions](https://github.com/launchdarkly/gh-actions) to permit the latest version. - [Release notes](https://github.com/launchdarkly/gh-actions/releases) - [Commits](https://github.com/launchdarkly/gh-actions/commits/release-secrets-v1.2.2) --- updated-dependencies: - dependency-name: launchdarkly/gh-actions dependency-version: 1.2.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9705bea. Configure here.
|
|
||
| - name: Sign DLLs | ||
| uses: launchdarkly/gh-actions/actions/sign-dlls@sign-dlls-v1.0.0 | ||
| uses: launchdarkly/gh-actions/actions/sign-dlls@release-secrets-v1.2.2 |
There was a problem hiding this comment.
Wrong tag used for sign-dlls
High Severity
Dependabot retargeted sign-dlls from sign-dlls-v1.0.0 to release-secrets-v1.2.2. That tag belongs to a different action in the same monorepo, so the client SDK signing job now pins an unrelated ref. Releases can run a mismatched sign-dlls implementation or fail to resolve the action, breaking signed package publish.
Reviewed by Cursor Bugbot for commit 9705bea. Configure here.
There was a problem hiding this comment.
Risk: high.
Automated risk review (dry run): High
This PR would not be automatically approved. Human approval required.
Why: CI workflow files .github/workflows/publish-docs.yml and .github/workflows/release-sdk-client.yml were changed, and Dependabot retargeted sign-dlls from sign-dlls-v1.0.0 to the unrelated release-secrets-v1.2.2 tag. Cursor Bugbot reported that unresolved high-severity finding, so this cannot be Low.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Human review is needed and no reviewers were assigned.
Sent by Cursor Approval Agent: Dry-Run PR Approver
jsonbailey
left a comment
There was a problem hiding this comment.
Do not merge. This PR sets an invalid ref for launchdarkly/gh-actions:
sign-dlls@release-secrets-v1.2.2: the tag is for a different action
Dependabot treats all actions in launchdarkly/gh-actions as one dependency, because the tags use a dash between the action name and the version. It then moves every ref to the newest tag in the repo, even when that tag belongs to another action. The fix is in launchdarkly/gh-actions#137.




Updates the requirements on launchdarkly/gh-actions to permit the latest version.
Release notes
Sourced from launchdarkly/gh-actions's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Overview
Bumps
launchdarkly/gh-actions/actions/release-secretsfromrelease-secrets-v1.2.1torelease-secrets-v1.2.2inpublish-docsandrelease-sdk-client(build, sign, and publish jobs). That upstream release is a dependency patch for the secrets/SSM action (e.g. undici/vitest inrelease-secrets/ssm).The SDK client workflow also changes
sign-dllsfromsign-dlls-v1.0.0torelease-secrets-v1.2.2, while other release paths in the repo still pinsign-dlls-v1.0.0—worth confirming that tag is correct for the sign action.Reviewed by Cursor Bugbot for commit 9705bea. Bugbot is set up for automated code reviews on this repo. Configure here.