Repository navigation
fix(sdk): accept CRLF skill frontmatter in Go and Rust - #46
Merged
Merged
Conversation
Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
ghfind-review
Bot
added
the
review: medium
Collaborator
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A valid
SKILL.mdwith Windows CRLF line endings installs through the TypeScript and Python SDKs, but Go and Rust reject it withinvalid-frontmatterbecause their frontmatter delimiters only match LF.Normalize CRLF in the temporary text used for frontmatter parsing in Go and Rust. Bundle contents stay unchanged for copying and hashing. Add shared golden cases for a successful CRLF install with an original-byte metadata hash and rejection of an invalid skill name with CRLF.
Scope Check
spec/hosts.jsonchanges. (Not applicable; host data is unchanged.)Verification
make checkThe new install case fails against unchanged Go and Rust implementations (
installed: [],errors: [{reason: "invalid-frontmatter"}]) and passes with the fix. The full gate covers all four SDKs, 91 shared golden cases, standalone Go modules, Rustinclude-dirand clippy, Python lint/tests, and all four consumer examples.cargo fmt --check --manifest-path rust/Cargo.toml, Go formatting, andgit diff --checkalso pass.