Skip to content

docs: keep example commands in their own working directories - #45

Merged
samzong merged 1 commit into
lathe-cli:mainfrom
git-jxj:docs/fix-example-working-directories
Oct 2, 2026
Merged

samzong merged 1 commit into
lathe-cli:mainfrom
git-jxj:docs/fix-example-working-directories

Conversation

@git-jxj

@git-jxj git-jxj commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Pasting the example commands in sequence leaves the shell in examples/go, so the next cd examples/rust fails. Run each directory change in a subshell and state that the examples start from the repository root.

Scope Check

  • Stays within the v0.1 bundled-skill installer boundary.
  • Does not add marketplace, registry, private remote install, script execution, GUI, MCP server, or agent runtime behavior.
  • Updates golden cases for observable installer behavior changes. Not applicable: only the documented shell commands change.
  • Regenerates host constants after spec/hosts.json changes. Not applicable: the host spec is unchanged.

Verification

  • make check (including the four SDK examples)
  • Bash directory-navigation check fails on the old snippet and passes with the subshells; the final working directory remains the repository root.
  • bash -n and git diff --check

@git-jxj
git-jxj requested a review from samzong as a code owner October 2, 2026 09:43
@ghfind-review ghfind-review Bot added the review: medium ghfind author score; see https://ghfind.com label Oct 2, 2026

@samzong samzong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@samzong
samzong merged commit c526c24 into lathe-cli:main Oct 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review: medium ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants